Bug 8052 – smarty truncate not counting correctly

Bug 8052 - smarty truncate not counting correctly

Summary:

smarty truncate not counting correctly

Status:	RESOLVED FIXED

Product:	OJS
Classification:	Unclassified
Component:	User Interface
Version:	3.0a
Platform:	All All

Importance:	P3 normal
Assigned To:	PKP Support

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-12-04 08:17 PST by jerico
Modified:	2013-01-18 14:54 PST (History)
CC List:	2 users (show)

See Also:
Version Reported In:
Also Affects:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description jerico 2012-12-04 08:17:49 PST

Some of the citation output tests broke (some time ago). I now looked a bit closer and it seems that the PKP's own smarty truncate function doesn't work correctly: truncate:4 truncates after 5 characters.

Nlm30CitationSchemaApaFilterTest (and all other citation output tests) reproduce the problem:

expected: (2000)
actual: (2000-)

Comment 1 beghelli 2013-01-18 14:54:02 PST

This (https://github.com/pkp/pkp-lib/commit/746ec2d4ef726c9d64a6c2aae193d51a54e47386) fix to the truncate function also fixed the test that Florian pointed out. Not sure if we have more problems with the truncate function, but I didn't found any when I fixed it.

Comment 2 Alec Smecher 2013-01-18 14:54:46 PST

Thanks, Bruno.