PKP Bugzilla – Bug 7988
Email to All institutional subscribers in Editor "Notify users" function broken
Last modified: 2012-10-29 15:44:03 PDT
Should add function &getSubscribedUsers to classes/subscription/InstitutionalSubscriptionDAO.inc.php function &getSubscribedUsers($journalId, $rangeInfo = null) { $result =& $this->retrieveRange( 'SELECT u.* FROM subscriptions s, subscription_types st, users u WHERE s.type_id = st.type_id AND st.institutional = 0 AND s.user_id = u.user_id AND s.journal_id = ? ORDER BY u.last_name ASC, s.subscription_id', array((int) $journalId), $rangeInfo ); $userDao =& DAORegistry::getDAO('UserDAO'); $returner = new DAOResultFactory($result, $userDao, '_returnUserFromRow'); return $returner; }
Notify users institutional subscribers broken https://github.com/pkp/ojs/commit/b7051a671e4e36ebb26ae552d331d5d8d04c6a48
Notify users institutional subscribers broken https://github.com/pkp/ojs/commit/79580e4a5fa6e0998db09cda8ea9ebb2a085feaf
Notify users institutional subscribers broken https://github.com/pkp/ojs/commit/3aac4db3fb0b0f4bd8aac4501a5aaef757e3d42b
(In reply to comment #0) > Should add function &getSubscribedUsers to > classes/subscription/InstitutionalSubscriptionDAO.inc.php > .... > WHERE s.type_id = st.type_id AND > st.institutional = 0 AND Thanks for the bug report. Please see the attached patch for a fix, which differs slightly from the suggested patch above (i.e. st.institutional = 1).
Created attachment 3883 [details] Patch against OJS 2.3.8 (should also work with 2.3.7, 2.3.6, etc.)
Created attachment 3884 [details] Patch against OJS 2.4.1
Fixed.