PKP Bugzilla – Bug 7900
Editor needs an email log.
Last modified: 2014-11-04 18:41:02 PST
Editor needs an email log. (Consider also implicit ways of doing this, e.g. having clickable entries in the event log for emails.)
*** Bug 8456 has been marked as a duplicate of this bug. ***
Deferring (probably impacted by UI/UX)
Bruno, over to you for review.
Bruno, I added the items discussed in the UX review. I didn't add the close button. In fact I couldn't find a close button used anywhere. I noticed that in forms we have a cancel link on the bottom left but this won't be applicable here. I will look into the dropshadow issue in a separate ticket as this is a general UI issue.
Over to you for review.
For reference, Alec created a ticket for the modal in modal shadow issue. #8681
Bruno, I fixed the overlay issue in 8681 as well. This depends now 8681 being merged first.
Bruno, thanks for reviewing. I fixed the issues you pointed out. I left the one assert() as it is, as it basically just extended on the way it was handled before. Other than that I implemented all your suggested changes.
Michael, if we are going to use the getAssocId from any object, it is always good to check the assoc type, otherwise we might end up using the id from a different object. That's why I said to check the assoc type there, because you use the assoc id expecting it to be an id from a submission.
beyond my last commit, nothing else to add. It's up to you. :)
Added email history to the submission event log