Bug 7882 – Submission file downloads fail for editors in review stage

Bug 7882 - Submission file downloads fail for editors in review stage

Summary:

Submission file downloads fail for editors in review stage

Status:	RESOLVED FIXED

Product:	OJS
Classification:	Unclassified
Component:	Editors
Version:	2.4.1
Platform:	All All

Importance:	P3 normal
Assigned To:	PKP Support

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-09-12 09:57 PDT by Jason Nugent
Modified:	2012-09-20 13:15 PDT (History)
CC List:	1 user (show)

See Also:
Version Reported In:
Also Affects:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jason Nugent 2012-09-12 09:57:31 PDT

The downloadFile method in SubmissionEditHandler is missing a request parameter, so the call to redirect() generates a fatal error.

Comment 1 Jason Nugent 2012-09-12 10:00:02 PDT

add missing request parameter
https://github.com/pkp/ojs/commit/b525970a9dcfca49e9f4eda1a61556b93ffe31da

Comment 2 Alec Smecher 2012-09-12 10:07:06 PDT

Jason, can you add this to the 2.4.0 recommended patch list? I think we'll probably release 2.4.1 against a separate fork from 2.4.0 to avoid having to re-test with changes to lib-pkp since then, so I'll likely be using that list as the "definitive" list of bug fixes that need inclusion.

Comment 3 Alec Smecher 2012-09-20 13:15:03 PDT

add missing request parameter
https://github.com/pkp/ojs/commit/6bd874f0aa59dc6cbb416e5e555bcc8dace86286