Bug 7778 – Fix Paypal number formatting for locales using "," as a decimal delimiter

Bug 7778 - Fix Paypal number formatting for locales using "," as a decimal delimiter

Summary:

Fix Paypal number formatting for locales using "," as a decimal delimiter

Status:	RESOLVED FIXED

Product:	OJS
Classification:	Unclassified
Component:	Payments
Version:	2.4.0
Platform:	All All

Importance:	P3 normal
Assigned To:	PKP Support

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-08-20 09:46 PDT by Alec Smecher
Modified:	2012-08-20 11:30 PDT (History)
CC List:	0 users

See Also:
Version Reported In:
Also Affects:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alec Smecher 2012-08-20 09:46:50 PDT

Fix Paypal number formatting for locales using "," as a decimal delimiter. See http://pkp.sfu.ca/support/forum/viewtopic.php?f=8&t=8960 for details.

Comment 1 Alec Smecher 2012-08-20 09:53:48 PDT

It looks like the fix proposed in the forums will work well for the general case. (See <http://stackoverflow.com/questions/498920/what-is-the-paypal-amount-format-in-wps>.)

Comment 2 Alec Smecher 2012-08-20 10:09:26 PDT

Committed also to OCS (pre-2.4.0) and OMP (pre-1.0b) master repos.

Comment 3 Alec Smecher 2012-08-20 10:30:03 PDT

Fixed number formatting for certain locales
https://github.com/pkp/ocs/commit/f2a847d9d24954b481a4456e60e00c053179d893

Comment 4 Alec Smecher 2012-08-20 11:30:03 PDT

Fixed number formatting for certain locales
https://github.com/pkp/ojs/commit/ee36f74bdfb7830f8f2a80cfd91a6ddb57d5f0d4