Bug 7681 – Check for bots in all cases when incrementing view counts

Bug 7681 - Check for bots in all cases when incrementing view counts

Summary:

Check for bots in all cases when incrementing view counts

Status:	RESOLVED FIXED

Product:	OJS
Classification:	Unclassified
Component:	General
Version:	2.4.0
Platform:	All All

Importance:	P3 normal
Assigned To:	PKP Support

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-07-09 16:16 PDT by Matthew Crider
Modified:	2012-07-09 16:37 PDT (History)
CC List:	1 user (show)

See Also:
Version Reported In:
Also Affects:

Attachments
Patch against OJS 2.3.7 (1021 bytes, patch) 2012-07-09 16:26 PDT, Matthew Crider	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Matthew Crider 2012-07-09 16:16:13 PDT

There are a couple places in ArticleHandler that are not checking for bots when incrementing galley view counts.  This may cause issues down the line for journals that start getting lower view counts but they should not have been recording bots in the first place.

Comment 1 Matthew Crider 2012-07-09 16:20:03 PDT

Check for bots in all cases when incrementing view counts
https://github.com/pkp/ojs/commit/aa9dba7a3ea25028479c27a1783e22029b271f07

Comment 2 Matthew Crider 2012-07-09 16:25:01 PDT

Check for bots in all cases when incrementing view counts
https://github.com/pkp/ojs/commit/9bdf919412594db1abee51ef8ac147f5fc0aaaf8

Comment 3 Matthew Crider 2012-07-09 16:26:52 PDT

Created attachment 3815 [details]
Patch against OJS 2.3.7

Comment 4 Matthew Crider 2012-07-09 16:27:09 PDT

Added to patches list; Closing.

Comment 5 Alec Smecher 2012-07-09 16:34:24 PDT

I could swear we recently caught and fixed this one -- but looks like we didn't. Thanks.

Comment 6 Matthew Crider 2012-07-09 16:37:09 PDT

I caught it in a recent customization; But we both agreed it was best to file it separately since it could (will) have an impact on journal's view counts.