Bug 7438 - CIDR suffix removed from IP range display for institutional subscriptions
CIDR suffix removed from IP range display for institutional subscriptions
Status: RESOLVED FIXED
Product: OJS
Classification: Unclassified
Component: Subscriptions
2.3.8
All All
: P3 normal
Assigned To: Michael Felczak
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-08 14:31 PDT by Michael Felczak
Modified: 2012-05-08 15:00 PDT (History)
1 user (show)

See Also:
Version Reported In: 2.3.7
Also Affects:


Attachments
Patch against OJS 2.3.7 (should also work with 2.3.6, 2.3.5, etc.) (967 bytes, patch)
2012-05-08 14:34 PDT, Michael Felczak
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Felczak 2012-05-08 14:31:35 PDT
IP addresses entered using CIDR notation (e.g. 192.168.1.100/30) have the end (e.g. /30) removed and appear as just the base IP address (e.g. 192.168.1.100) on subsequent edits to an institutional subscription.

The CIDR IP range is being saved to the correct values in the db, but because the CIDR is being removed on display of the form, subsequent edits/saves to the subscription will overwrite the previously correct values in the db with the base IP address of the range.
Comment 1 Michael Felczak 2012-05-08 14:34:27 PDT
Created attachment 3774 [details]
Patch against OJS 2.3.7 (should also work with 2.3.6, 2.3.5, etc.)
Comment 2 Michael Felczak 2012-05-08 14:35:02 PDT
CIDR suffix removed from IP range display for institutional subscriptions
https://github.com/pkp/ojs/commit/40d01d3fdda123a322655acffef54e5742dca33f
Comment 3 Michael Felczak 2012-05-08 14:45:02 PDT
CIDR suffix removed from IP range display for institutional subscriptions
https://github.com/pkp/ojs/commit/5b1fc94968e0e6a1816a6f46ecd31337ac17a515
Comment 4 Michael Felczak 2012-05-08 15:00:59 PDT
Fixed.