Bug 6968 – Check review_type constant behavior

Bug 6968 - Check review_type constant behavior

Summary:

Check review_type constant behavior

Status:	RESOLVED FIXED

Product:	OJS
Classification:	Unclassified
Component:	General
Version:	2.4.2
Platform:	All All

Importance:	P3 normal
Assigned To:	PKP Support

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-12-07 14:02 PST by Alec Smecher
Modified:	2012-12-14 15:20 PST (History)
CC List:	0 users

See Also:
Version Reported In:
Also Affects:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alec Smecher 2011-12-07 14:02:58 PST

Check review_type constant behavior in review_assignments. It's unclear whether OJS expects it to be 1 (default column value) or 0 (new inserts seem to go that way). May need upgrade attention.

Comment 1 Alec Smecher 2012-12-14 14:26:46 PST

(review_type was renamed to stage_id.)

Comment 2 Alec Smecher 2012-12-14 15:15:02 PST

Check stage_id constant behavior
https://github.com/pkp/ojs/commit/f2bab10eb78a17c617b3e5522fcacf0441b10da6

Comment 3 Alec Smecher 2012-12-14 15:20:02 PST

Check stage_id constant behavior
https://github.com/pkp/ojs/commit/cac009199f0653cfdb9a860660a1d97b20b97c4b