Bug 6915 – Review due date incorrectly set and displayed for paper review

Bug 6915 - Review due date incorrectly set and displayed for paper review

Summary:

Review due date incorrectly set and displayed for paper review

Status:	REOPENED

Product:	OCS
Classification:	Unclassified
Component:	Review
Version:	3.x
Platform:	All All

Importance:	P3 normal
Assigned To:	Michael Felczak

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-10-06 09:19 PDT by Michael Felczak
Modified:	2012-09-24 10:51 PDT (History)
CC List:	2 users (show)

See Also:
Version Reported In:
Also Affects:

Attachments
Screenshots with additional details (720.23 KB, application/pdf) 2011-10-06 09:20 PDT, Michael Felczak	Details
Patch against OCS 2.3.3-1 (1.45 KB, patch) 2011-10-07 16:42 PDT, Michael Felczak	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Felczak 2011-10-06 09:19:58 PDT

On Director's submission review page.

Please see attachment for additional details.

Courtesy of:
http://pkp.sfu.ca/support/forum/viewtopic.php?f=3&t=7887&p=30921#p30911

Comment 1 Michael Felczak 2011-10-06 09:20:57 PDT

Created attachment 3651 [details]
Screenshots with additional details

Comment 2 Michael Felczak 2011-10-07 16:34:41 PDT

For 2-stage review, after abstract review is completed and reviewer assignments from abstract review are set as defaults for paper review.

Comment 3 Michael Felczak 2011-10-07 16:40:02 PDT

Review due date incorrectly set and displayed for paper review
https://github.com/pkp/ocs/commit/24feaba7fd52ffa317cb6ce82a3e3bd7776c642e

Comment 4 Michael Felczak 2011-10-07 16:42:41 PDT

Created attachment 3655 [details]
Patch against OCS 2.3.3-1

Comment 5 Michael Felczak 2011-10-07 16:45:01 PDT

Review due date incorrectly set and displayed for paper review
https://github.com/pkp/ocs/commit/17ac7fcbd5675655207c7247e7f9983a53add33f

Comment 6 Michael Felczak 2011-10-07 16:47:09 PDT

Fixed.

Comment 7 Alec Smecher 2011-10-07 17:04:59 PDT

Michael, I'm confused about this fix -- shouldn't the existing calls to TrackDirectorAction::setDueDate update the due date field?

Comment 8 Michael Felczak 2011-10-07 17:22:13 PDT

This was confusing for me as well. 

Although the due date is initially correctly updated in the db, the review assignment itself in the track submission is not updated with this new date info.

The now-stale track submission is then updated in the db, wiping the previously set due date.

Comment 9 Alec Smecher 2011-10-07 20:46:44 PDT

OK, though the patch is more of a work-around than a fix -- I'd suggest leaving this open for a better clean-up when we get the chance.