We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.

Bug 6902 - Introduce review round id and refactor all existing related code
Introduce review round id and refactor all existing related code
Status: RESOLVED FIXED
Product: OJS
Classification: Unclassified
Component: Reviewers
3.0a
All All
: P3 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-03 05:07 PDT by beghelli
Modified: 2014-04-16 13:23 PDT (History)
3 users (show)

See Also:
Version Reported In:
Also Affects:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description beghelli 2011-10-03 05:07:06 PDT
Introduce a review round id so we can stop using the stage id and round to get a review round object. Need to go through all the workflow code for refactoring.
Comment 1 beghelli 2011-10-04 20:36:31 PDT
Removed method collateral effect, corrected review round status update
https://github.com/pkp/omp/commit/db46bc369c553141bb7c1b88308a79e73003966d
Comment 2 beghelli 2011-10-04 20:50:03 PDT
Removed method collateral effect, corrected review round status update
https://github.com/pkp/omp/commit/db46bc369c553141bb7c1b88308a79e73003966d
Comment 3 beghelli 2011-10-05 04:45:03 PDT
Check status and round before insert a review round in database
https://github.com/pkp/omp/commit/95ae7549aee0904909dfda2eb498103b10126eba
Comment 4 beghelli 2011-10-05 04:45:03 PDT
Update the correct review round status after inserting a first reviewer
https://github.com/pkp/omp/commit/d9a0671c80f1e1b747060b49c6b69b00a11ea83e
Comment 5 Alec Smecher 2011-10-18 17:05:02 PDT
Decrease duplication of decision checks
https://github.com/pkp/omp/commit/0865074fc62ce39b47bb6223edfa296b0b65940d
Comment 6 beghelli 2011-10-27 11:35:01 PDT
Start to authorize access to review rounds using the review round id
https://github.com/pkp/omp/commit/50f358344653c510a8a600be69d43cc6db329504
Comment 7 beghelli 2011-10-27 11:50:02 PDT
Start to authorize access to review rounds using the review round id
https://github.com/pkp/omp/commit/50f358344653c510a8a600be69d43cc6db329504
Comment 8 beghelli 2011-10-27 11:50:02 PDT
Centralized business logic around decisions and other small fixes
https://github.com/pkp/omp/commit/4e61eac134ad7dbf988816fde91f55f8e7681f14
Comment 9 beghelli 2011-10-27 11:50:02 PDT
Pass the current stage id instead of the next one that will be initiated
https://github.com/pkp/omp/commit/cd86011992a517674be1a7a9b4f143b274ab0bfb
Comment 10 beghelli 2011-10-27 12:05:01 PDT
Centralized business logic around decisions and other small fixes
https://github.com/pkp/omp/commit/4e61eac134ad7dbf988816fde91f55f8e7681f14
Comment 11 beghelli 2011-10-27 12:05:02 PDT
Pass the current stage id instead of the next one that will be initiated
https://github.com/pkp/omp/commit/cd86011992a517674be1a7a9b4f143b274ab0bfb
Comment 12 beghelli 2011-11-01 06:45:02 PDT
Insert review round id column in review assignments table
https://github.com/pkp/pkp-lib/commit/d47a970302f0937ebf42bdfaffa217ba10b6b671
Comment 13 beghelli 2011-11-01 07:15:02 PDT
Define the review round join sql in DAO subclass
https://github.com/pkp/ojs/commit/2018c1739d9f1c24adc24157d5fade5597f0204f
Comment 14 beghelli 2011-11-01 07:15:02 PDT
Define the review round join sql in DAO subclass
https://github.com/pkp/ocs/commit/5b8d45eda902fc32e5c1a23e7898f4da3b945839
Comment 15 beghelli 2011-11-04 17:00:03 PDT
More review round overhaul
https://github.com/pkp/omp/commit/5be847d77825c744b6366bf7dee7aacfba689414
Comment 16 beghelli 2011-11-04 17:00:03 PDT
Use optional review round id in getInternally method
https://github.com/pkp/pkp-lib/commit/ac41bdb8eefce3a2ccb60ba1271db54ebf5ceea4
Comment 17 Alec Smecher 2012-01-06 09:35:20 PST
Finished for OMP. Needs back-porting to other applications.
Comment 18 Alec Smecher 2013-08-07 13:51:03 PDT
Refactor review assignment DAO overrides into lib-pkp
https://github.com/pkp/pkp-lib/commit/9b3e5c2aaf0fcc1932a9a1be3cb8cf40a401f298
Comment 19 Alec Smecher 2013-08-07 13:51:03 PDT
Refactor review assignment DAO overrides into lib-pkp
https://github.com/pkp/ojs/commit/959abf5a522db13211597bfee6096b8165fb3339
Comment 20 Alec Smecher 2013-08-07 13:59:02 PDT
Dead code removal
https://github.com/pkp/omp/commit/b4f02d9787e576257e3dcec82eaaa4cabccdf1a7
Comment 22 Alec Smecher 2013-08-07 14:35:02 PDT
Refactor all of ReviewAssignment/DAO into PKP lib
https://github.com/pkp/pkp-lib/commit/01c652215c98245c7e8f565a0286f3ffcb874160
Comment 23 Alec Smecher 2013-08-07 14:36:02 PDT
Refactor all of ReviewAssignment/DAO into PKP lib
https://github.com/pkp/omp/commit/5dd875e139de60818cdb40276972773c91176ee9
Comment 24 Alec Smecher 2013-08-07 14:36:02 PDT
Refactor all of ReviewAssignment/DAO into PKP lib
https://github.com/pkp/ojs/commit/554c5a0a2eab5966ee30d7bbba32e4dd5e18febe
Comment 25 Alec Smecher 2014-04-16 13:20:02 PDT
Remove unnecessary subclass extensions
https://github.com/pkp/pkp-lib/commit/b128bde9892e990fe487a112c9b70ca8cecf60c8
Comment 26 Alec Smecher 2014-04-16 13:21:02 PDT
Remove unnecessary subclass extensions
https://github.com/pkp/omp/commit/6e95aa168344a282218cac9cd398dd93cdad4399
Comment 27 Alec Smecher 2014-04-16 13:23:02 PDT
Remove unnecessary subclass extensions
https://github.com/pkp/ojs/commit/94278e2771982a135498887960b026cc8c9ae642