PKP Bugzilla – Bug 6901
Fontsizer Tooltips hardcoded in English Language
Last modified: 2012-12-19 13:25:01 PST
Created attachment 3647 [details] Changed /plugins/blocks/fontSize/block.tpl Since the Fontsizer JS introduces it's needed hrefs into the DOM of all pages itself, a localization of the tooltip texts is not possible through Smarty. Removing the introduction of the 3 button hrefs from /lib/pkp/js/fontController.js and putting them instead into /plugins/blocks/fontSize/block.tpl using the Smarty localization mechanism in that case, makes OJS show localized Tooltips. Attached are the changed files.
Created attachment 3648 [details] Changed /lib/pkp/js/fontController.js
Thanks for the fix, Philip. Unfortunately we can't integrate it as is, because we're trying as much as possible not to modify external code -- better to either find a more configurable font controller or contribute an improvement to this one to make it configurable. I'll leave this entry open until someone gets a chance to tackle it; in the meantime, your work-around looks good.
Swapped out the font controller for one without hard-coded English.
New font controller https://github.com/pkp/ojs/commit/c6c7ea4050ab55ca00a2c8023b6ece7e93f009cc
Remove leftovers from old font controller https://github.com/pkp/pkp-lib/commit/f3c69f721baee02d53e7f5bbfce8e97177ed0fb9
New font controller https://github.com/pkp/ocs/commit/a3f9ab4a71309906dfd6659a6f37cd3c21a2dcb3
New font controller cleanup https://github.com/pkp/ojs/commit/ef411db7877a2e7a751ba70d79650dff115c75f5
Removed leftover images https://github.com/pkp/pkp-lib/commit/37efdb7e9067bf16f8c91f3a6029a2d922915eb3
New font controller cleanup https://github.com/pkp/omp/commit/fc7a68d56b799f174f528870ba1c1149e424a9f9