PKP Bugzilla – Bug 6888
Review Due Date can only be set up to 2011
Last modified: 2011-09-19 12:06:20 PDT
(Courtesy of http://pkp.sfu.ca/support/forum/viewtopic.php?f=3&t=7887&p=30635#p30635) In Conference Management -> Scheduled Conference Setup -> Step 3.2, the Conference Manager can choose 2011 as the latest default due date for a review to be completed. CMs should be able to select at least a year in advance, especially for Fall submissions. The relevant snippet from the tpl file (templates/manager/schedConfSetup/step3.tpl) is as follows: {html_select_date prefix="numWeeksPerReviewAbsolute" time=$absoluteReviewDate all_extra="class=\"selectMenu\"" start_year=$firstYear end_year=$lastYear} ... and $lastYear is assigned as follows in various places (/classes/manager/form/scheduler/ScheduleForm.inc.php:132, /classes/manager/form/scheduler/SpecialEventForm.inc.php:66, /classes/manager/form/TimelineForm.inc.php:143): $templateMgr->assign('lastYear', strftime('%Y', $latestDate)) What's the best way to increment this? Should the assignment be changed, or should a new, schedConfSetup->Step3 assignment be made? (NB.: I think this is significant enough to get in for 2.3.4, especially if we release in the Fall. :D)
Created attachment 3642 [details] Patch against OCS 2.3.3-1
Review Due Date can only be set up to 2011 https://github.com/pkp/ocs/commit/7195615e079bb9f58c201dbc4bed35f3a1f282c1
Thanks, James. In sched conf setup 3.2, neither start year nor end year were actually being set for the template -- by default the end year is the current year. The end year on the other pages looks to be correctly set into the future.
Review Due Date can only be set up to 2011 https://github.com/pkp/ocs/commit/b75dab853c8590983a29af9889dc0bd28c8f5080
Fixed.
Created attachment 3643 [details] Patch against OCS 2.3.3-1
Review Due Date can only be set up to 2011 https://github.com/pkp/ocs/commit/fcaaac39b6a0c985f63d0be4ffded682562dc67d
Review Due Date can only be set up to 2011 https://github.com/pkp/ocs/commit/5b98cbf9cc59c748371d10a71c2ff5a3ec4219c4
Improved fix uses year offset window based on sched conf timeline. This is more consistent with setting of start and end years in other parts of the system.
Review Due Date can only be set up to 2011 https://github.com/pkp/ocs/commit/3481edfbe5bb5d4102c3f90ad91a0198f5c07907
Review Due Date can only be set up to 2011 https://github.com/pkp/ocs/commit/5d448f97a00e8eddaace6e4d3b1d402eb92cbe63