Bug 6886 – submission metadata template displaying raw HTML for affiliation

Bug 6886 - submission metadata template displaying raw HTML for affiliation

Summary:

submission metadata template displaying raw HTML for affiliation

Status:	RESOLVED FIXED

Product:	OCS
Classification:	Unclassified
Component:	User Interface
Version:	2.3.4
Platform:	All All

Importance:	P3 normal
Assigned To:	PKP Support

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-09-14 14:18 PDT by James MacGregor
Modified:	2011-09-14 14:25 PDT (History)
CC List:	0 users

See Also:
Version Reported In:
Also Affects:

Attachments
Patch against OCS 2.3.3-1 (604 bytes, patch) 2011-09-14 14:24 PDT, James MacGregor	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description James MacGregor 2011-09-14 14:18:04 PDT

Any HTML tags generated as part of the submission metadata -> affiliation field (stored in paper_authors.affiliation in the DB) are displayed when viewing the submission's metadata via templates/submission/metadata/metadata.tpl. It looks to me like the 'escape' parameter should be changed to 'strip_unsafe_html':

<td class="value">{$author->getLocalizedAffiliation()|escape|nl2br|default:"&mdash;"}</td>

... should be:

<td class="value">{$author->getAffiliation()|strip_unsafe_html|nl2br|default:"&mdash;"}</td>

Comment 1 James MacGregor 2011-09-14 14:20:02 PDT

submission metadata template displaying raw HTML for affiliation
https://github.com/pkp/ocs/commit/1af3ef48c88cd8ae1180dd94b1ab6687813123f6

Comment 2 James MacGregor 2011-09-14 14:24:45 PDT

Created attachment 3640 [details]
Patch against OCS 2.3.3-1

Comment 3 James MacGregor 2011-09-14 14:25:02 PDT

submission metadata template displaying raw HTML for affiliation
https://github.com/pkp/ocs/commit/7b64c1a2678f0e11d9b72d65c77e197a9cea0568

Comment 4 James MacGregor 2011-09-14 14:25:34 PDT

Committed to both stable and master. Closing.