Bug 6878 - Problems saving Custom Review forms
Problems saving Custom Review forms
Status: NEW
Product: OJS
Classification: Unclassified
Component: Reviewers
2.4.x
All All
: P3 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-08 11:32 PDT by James MacGregor
Modified: 2012-09-21 14:57 PDT (History)
1 user (show)

See Also:
Version Reported In:
Also Affects: OCS 2.3.x


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James MacGregor 2011-09-08 11:32:04 PDT
If a journal is using custom review forms and configures one or more fields to be required (ie. reviewers must complete them), reviewers encounter an error if they attempt to save the review with one or more required fields uncompleted: 

Errors occurred processing this form:

    Please fill in required fields.

At the same time, the form is *not* saved. While technically this is expected behaviour, it doesn't match reviewer expectations. Since the form is revisitable, reviewers may expect that clicking the "save" button will save the form regardless (especially since the form data appears when the page reloads), only to be surprised when they revisit after logging out/quitting the browser to find a blank form. 

We should probably add some sort of workaround here to better serve reviewers: either/and/or:

- make the error text bigger, and include something to the effect that "This form has not been saved";

- save the form regardless, while still presenting the error; but don't let the reviewer complete the review until the required fields have been filled (tricky?);

- have some sort of popup that asks if the reviewer wants to save the form anyway, even if all required elements haven't been filled. 

There are probably other, better workarounds than this. Comments?