We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.

Bug 6752 - iBrowser fail using pt_br language
iBrowser fail using pt_br language
Status: RESOLVED FIXED
Product: OJS
Classification: Unclassified
Component: Plug-ins
2.3.7
All Linux
: P3 normal
Assigned To: Matthew Crider
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-10 06:27 PDT by ebettoni
Modified: 2012-01-11 14:14 PST (History)
2 users (show)

See Also:
Version Reported In:
Also Affects:


Attachments
Patch against pkp-lib stable (17.25 KB, patch)
2012-01-11 11:31 PST, Matthew Crider
Details | Diff
Patch against pkp-lib stable (1.73 KB, patch)
2012-01-11 13:51 PST, Matthew Crider
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ebettoni 2011-07-10 06:27:22 PDT
I've installed the latest version of ojs (2.3.6) in my server. 

I've no problems during this process, but, when I try to use the ibrowser (clicking in the image button on tiny), it returns this message (new window):

"invalid language set"

If I set another language (en, es), there's no problem. The "pt_br" is the only one that has a "_", but I really don't if it makes any difference.
Comment 1 Luiz Borges 2012-01-11 05:41:23 PST
Any news on that matter?
Comment 2 Matthew Crider 2012-01-11 11:25:02 PST
Set default iBrowser language to English and fix Portuguese translation
https://github.com/pkp/pkp-lib/commit/178b0642c0cea0b9d7b094a5a02f501150f2f75d
Comment 3 Matthew Crider 2012-01-11 11:25:02 PST
Set default iBrowser language to English and fix Portuguese translation
https://github.com/pkp/pkp-lib/commit/b052b5ad617a21ee063593ab178e70b87ce3377d
Comment 4 Matthew Crider 2012-01-11 11:31:48 PST
Created attachment 3691 [details]
Patch against pkp-lib stable

Must be applied to the lib/pkp/ subdirectory of OJS (or other PKP application).
Comment 5 Alec Smecher 2012-01-11 11:40:10 PST
Matt, this will add an extra step that's likely to be forgotten when updating iBrowser from upstream. I'd rather we added instead an associative map linking OJS languages to iBrowser languages, i.e.:

$map = array('en_US' => 'en', 'fr_CA' => 'fr', 'pt_BR' => 'pt_br');
Comment 6 Matthew Crider 2012-01-11 13:50:02 PST
Updated iBrowser language handling
https://github.com/pkp/pkp-lib/commit/35273f9cc304b6483ca3f2275299f1673e27d787
Comment 7 Matthew Crider 2012-01-11 13:50:02 PST
Updated iBrowser language handling
https://github.com/pkp/pkp-lib/commit/19a34110960631c1745d26195413cd571d02cfba
Comment 8 Matthew Crider 2012-01-11 13:51:29 PST
Created attachment 3692 [details]
Patch against pkp-lib stable
Comment 9 Alec Smecher 2012-01-11 14:06:21 PST
Thanks, Matt -- looks good.