We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.

Bug 6723 - Some ICO file types don't upload for favicon
Some ICO file types don't upload for favicon
Status: RESOLVED FIXED
Product: PKP-LIB
Classification: Unclassified
Component: General
Undetermined
All All
: P3 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-27 12:24 PDT by Matthew Crider
Modified: 2014-10-07 12:38 PDT (History)
1 user (show)

See Also:
Version Reported In:
Also Affects:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Crider 2011-06-27 12:24:28 PDT
ICO files with MIME type image/x-ico do not pass image file type validation.
Comment 1 Matthew Crider 2011-06-27 12:27:44 PDT
Fixed. 

https://github.com/pkp/pkp-lib/commit/e19bf284388dc373097ad53462443954a272d468

Michael/Alec, its too late to put this in the stable branch?
Comment 2 Alec Smecher 2011-06-27 12:34:48 PDT
No -- go ahead and chuck it in there.
Comment 4 Matthew Crider 2011-06-27 12:43:11 PDT
(Oh and, thanks to Pety on the forums for the fix: http://pkp.sfu.ca/support/forum/viewtopic.php?f=3&t=7663&p=29691#p29691)
Comment 5 Matthew Crider 2014-10-07 12:38:28 PDT
Some ICO file types don't upload for favicon
https://github.com/pkp/pkp-lib/commit/e725ea526683f2ddc1834646a1bdeb48835bad04