Bug 6667 – Upgrade does not mark old version as no longer current

Bug 6667 - Upgrade does not mark old version as no longer current

Summary:

Upgrade does not mark old version as no longer current

Status:	RESOLVED FIXED

Product:	OJS
Classification:	Unclassified
Component:	Installer
Version:	2.3.6
Platform:	All All

Importance:	P3 normal
Assigned To:	Michael Felczak

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-06-01 18:00 PDT by Michael Felczak
Modified:	2011-06-21 07:04 PDT (History)
CC List:	3 users (show)

See Also:
Version Reported In:	2.3.5
Also Affects:

Attachments
Patch against OJS 2.3.5 (1.40 KB, patch) 2011-06-01 18:04 PDT, Michael Felczak	Details \| Diff
Patch against OJS 2.3.5 (apply against lib/pkp + see db fix below) (2.09 KB, patch) 2011-06-01 19:00 PDT, Michael Felczak	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Felczak 2011-06-01 18:00:55 PDT

Only the most recently installed version should be marked as current.

Comment 1 Michael Felczak 2011-06-01 18:04:37 PDT

Created attachment 3531 [details]
Patch against OJS 2.3.5

Comment 2 Michael Felczak 2011-06-01 19:00:40 PDT

Created attachment 3532 [details]
Patch against OJS 2.3.5 (apply against lib/pkp + see db fix below)

Comment 3 Michael Felczak 2011-06-01 19:04:06 PDT

Patch marks old version as no longer current for manual install.

Patch restores marking of old version as no longer current in VersionDAO.

Comment 4 Michael Felczak 2011-06-01 19:07:19 PDT

Need to manually update versions table to fix this bug after an upgrade to OJS 2.3.5:

UPDATE versions SET current = 0 WHERE product = 'ojs2';

UPDATE versions SET current = 1 WHERE product = 'ojs2' AND major = 2 AND minor = 3 AND revision = 5;

Comment 5 Michael Felczak 2011-06-01 19:12:23 PDT

Committed to ojs_stable-2_3 and master:

https://github.com/pkp/pkp-lib/commit/de0224443d7c683b7506120e4cdd228343ff20bb
https://github.com/pkp/pkp-lib/commit/3cd2a49075f7ef0346aca6ac6296446dfb8aa4e4

Comment 6 Michael Felczak 2011-06-13 09:34:21 PDT

Additional notes:

The fix here reverts patch 3490 in Bug 6579 (Can't move custom blocks).

Tested custom blocks on a clean OJS install and customBlockManager version is correctly set to 1 upon install. Custom blocks can also be moved up/down and left/right.

Comment 7 Michael Felczak 2011-06-13 09:34:43 PDT

Closing.