Bug 6658 - Upgrade fails during post-install with email templates error
Upgrade fails during post-install with email templates error
Status: RESOLVED FIXED
Product: OJS
Classification: Unclassified
Component: Installer
2.3.5
All All
: P3 normal
Assigned To: Michael Felczak
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-24 12:20 PDT by Michael Felczak
Modified: 2011-05-24 13:43 PDT (History)
2 users (show)

See Also:
Version Reported In: 2.3.4
Also Affects:


Attachments
Patch against OJS 2.3.4 (739 bytes, patch)
2011-05-24 12:26 PDT, Michael Felczak
Details | Diff
Patch #2 against OJS 2.3.4 (1.03 KB, patch)
2011-05-24 12:49 PDT, Michael Felczak
Details | Diff
Patch against OJS 2.3.4 (needs to be applied against lib/pkp) (904 bytes, patch)
2011-05-24 13:37 PDT, Michael Felczak
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Felczak 2011-05-24 12:20:15 PDT
All upgrade steps complete successfully, but post-install fails with the following:

<snip>
[code: Installer Installer::addPluginVersions]
[post-install]
ERROR: Upgrade failed: DB:
##installer.installParseEmailTemplatesFileError##
Comment 1 Michael Felczak 2011-05-24 12:21:59 PDT
This was a side effect of Bug 5837 (wrong upgrade of plugins emailTemplates).

After checking for installed email templates, error is raised rather than continuing with the upgrade.
Comment 2 Michael Felczak 2011-05-24 12:26:47 PDT
Created attachment 3516 [details]
Patch against OJS 2.3.4

This patch needs to be applied against lib/pkp
Comment 3 Alec Smecher 2011-05-24 12:33:34 PDT
Are you sure, Michael? That fix looks odd to me. I suspect you're running into trouble parsing a plugin's email templates file and I don't think that change will correct it. Were you able to narrow down the problem e.g. to a particular plugin?
Comment 4 Michael Felczak 2011-05-24 12:42:20 PDT
Hi Alec,

Yes, fix has been tested. I ended up debugging it and found that the problem applied to all plugins with email templates.

Turns out this was correctly handled in master but not stable. Will update fix to match master.
Comment 5 Michael Felczak 2011-05-24 12:49:41 PDT
Created attachment 3517 [details]
Patch #2 against OJS 2.3.4

Subsequent patch based on master branch

This patch needs to be applied against lib/pkp
Comment 6 Michael Felczak 2011-05-24 13:37:04 PDT
Created attachment 3518 [details]
Patch against OJS 2.3.4 (needs to be applied against lib/pkp)

This patch needs to be applied against lib/pkp
Comment 7 Alec Smecher 2011-05-24 13:38:12 PDT
Sounds good, Michael -- thanks.