We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.

Bug 6620 - Change http to https for google JS loader
Change http to https for google JS loader
Status: NEW
Product: PKP-LIB
Classification: Unclassified
Component: General
Undetermined
All All
: P3 normal
Assigned To: PKP Support
: 6795 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-27 11:52 PDT by Matthew Crider
Modified: 2011-08-02 10:10 PDT (History)
3 users (show)

See Also:
Version Reported In:
Also Affects:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Crider 2011-04-27 11:52:42 PDT
If a user is running OxS on HTTPS, loading the Google CDN jQuery loader can lead to an error on certain browsers.  We should be able to just use https in all cases without any issues.
Comment 1 Chris Charles 2011-06-24 12:28:47 PDT
Should be able to use protocol-relative links:

Instead of "http://foo.bar" or "https://foo.bar", just use "//foo.bar". The browser will load foo.bar using the same protocol as the rest of the page.
Comment 2 Alec Smecher 2011-06-24 12:33:10 PDT
Thanks, Chris, I wasn't aware of those. One minor IE caveat: CSS files double-load. See http://stackoverflow.com/questions/4831741/can-i-change-all-my-http-links-to-just for details.

Matt, I'm not fond of forcing SSL for CDNs just in case someone is using HTTPS; there are very few HTTPS journals out there that I'm aware of.
Comment 3 Matthew Crider 2011-07-14 10:31:20 PDT
This is also an issue with the CC logo (see http://pkp.sfu.ca/support/forum/viewtopic.php?f=9&t=7708&p=29848).
Comment 4 Jason Nugent 2011-08-02 10:00:15 PDT
*** Bug 6795 has been marked as a duplicate of this bug. ***
Comment 5 Jason Nugent 2011-08-02 10:10:03 PDT
Change http to https for google JS loader
https://github.com/pkp/pkp-lib/commit/e701d20b9cc5788c216504a31b58c4284334e440