PKP Bugzilla – Bug 6557
Submission History log locale keys untranslated
Last modified: 2011-04-19 09:02:13 PDT
I'm seeing some untranslated locale keys in the interface for the following page: http://git/ojs/index.php/test/editor/submissionHistory/3 eg.: ##log.copyedit.copyeditFileSet##, #log.review.resubmit##, ##log.editor.restored##, probably more. These keys are actually in locale/en_US/locale.xml, so there must be something going on code-wise that is preventing them from being displayed.
Logging was rewritten post-2.3.x -- depending when those entries were inserted, they might be stored in different ways. Could you try to locate those entries in event_log (by assoc_id = 3)?
(In reply to comment #1) > Logging was rewritten post-2.3.x -- depending when those entries were inserted, > they might be stored in different ways. Could you try to locate those entries > in event_log (by assoc_id = 3)? Hi Alec, there's no event log in article_event_log with assoc_id = 3 in my local install; I can check a larger install if you think it's worthwhile. However, there are definitely untranslated log entries in that table. I'll send you a dump of it separately.
James, check event_log rather than article_event_log.
Sorry, James, my mistake. Could you check article_event_log with article_id = 3?
(In reply to comment #4) > Sorry, James, my mistake. Could you check article_event_log with article_id = > 3? Hi Alec, there are a number of untranslated keys stored in the message column of article_event_log for article_id = 3. They appear like "##log.review.resubmit##", "##log.copyedit.copyeditFileSet##", etc. Not every key for that article is untranslated -- it just appears to be certain keys. These keys aren't translated for other articles, either. The ones I'm seeing so far: ##log.review.resubmit## ##log.copyedit.copyeditFileSet## ##log.review.reviewerAssigned## ##log.review.reviewAcceptedByProxy## There may be others; my local install doesn't currently have a robust set of log files.
Created attachment 3486 [details] Patch against OJS pre-2.3.5
The patch won't correct existing entries. Not req'd in GIT HEAD because of the logging overhaul already committed there.
Created attachment 3494 [details] Patch against OJS pre-2.3.5 Corrected function name
*** Bug 6607 has been marked as a duplicate of this bug. ***