PKP Bugzilla – Bug 6543
Files sent to copyediting don't show date sent
Last modified: 2011-03-25 14:26:34 PDT
The file Ids from the review stage and the editing stage aren't matching up, causing the date sent to be hidden.
Fixed: https://github.com/pkp/ojs/commit/c0ba5604a8612513200989e2b5642c38d1c64133 Alec, is there any use for the source file id in article files anymore? It doesn't seem to be used anywhere functionally.
When a file goes from one part of the workflow to another, it gets a new file ID and starts counting again from an initial revision; the source_file_id and source_revision point back to the previous stage where the file came from. The conditional you changed was trying to determine whether or not the file in copyediting came from a particular file in the review stage -- I don't think the fix is correct. Are the source_file_id and source_revision not getting set?
Got it--The new file is being set in the signoff correctly in SectionEditorAction::setCopyeditFile(), but is being set again (to the original file) right after that method is called in SubmissionEditHandler::editorReview(). Fixed at: https://github.com/pkp/ojs/commit/349f14805a3012e342bffcdf35c1aae547497fcf Alec, if this is okay shall i put it in stable?
Yes, if you've tested it.
Created attachment 3474 [details] Patch against OJS pre-2.3.5
Pushed to official. https://github.com/pkp/ojs/commit/50f53e2bbe4742202bc1446c55ce03826c7bcf47