We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.

Bug 6543 - Files sent to copyediting don't show date sent
Files sent to copyediting don't show date sent
Status: RESOLVED FIXED
Product: OJS
Classification: Unclassified
Component: Editors
2.3.5
All All
: P3 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-24 18:01 PDT by Matthew Crider
Modified: 2011-03-25 14:26 PDT (History)
1 user (show)

See Also:
Version Reported In:
Also Affects:


Attachments
Patch against OJS pre-2.3.5 (795 bytes, patch)
2011-03-25 14:26 PDT, Matthew Crider
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Crider 2011-03-24 18:01:31 PDT
The file Ids from the review stage and the editing stage aren't matching up, causing the date sent to be hidden.
Comment 1 Matthew Crider 2011-03-24 18:12:49 PDT
Fixed: https://github.com/pkp/ojs/commit/c0ba5604a8612513200989e2b5642c38d1c64133

Alec, is there any use for the source file id in article files anymore?  It doesn't seem to be used anywhere functionally.
Comment 2 Alec Smecher 2011-03-24 18:28:14 PDT
When a file goes from one part of the workflow to another, it gets a new file ID and starts counting again from an initial revision; the source_file_id and source_revision point back to the previous stage where the file came from. The conditional you changed was trying to determine whether or not the file in copyediting came from a particular file in the review stage -- I don't think the fix is correct. Are the source_file_id and source_revision not getting set?
Comment 3 Matthew Crider 2011-03-25 13:52:46 PDT
Got it--The new file is being set in the signoff correctly in SectionEditorAction::setCopyeditFile(), but is being set again (to the original file) right after that method is called in SubmissionEditHandler::editorReview().

Fixed at:
https://github.com/pkp/ojs/commit/349f14805a3012e342bffcdf35c1aae547497fcf

Alec, if this is okay shall i put it in stable?
Comment 4 Alec Smecher 2011-03-25 14:17:28 PDT
Yes, if you've tested it.
Comment 5 Matthew Crider 2011-03-25 14:26:22 PDT
Created attachment 3474 [details]
Patch against OJS pre-2.3.5
Comment 6 Matthew Crider 2011-03-25 14:26:34 PDT
Pushed to official.

https://github.com/pkp/ojs/commit/50f53e2bbe4742202bc1446c55ce03826c7bcf47