Bug 6531 - "EDITOR NOTE" text hard-coded instead of actual note fetch
"EDITOR NOTE" text hard-coded instead of actual note fetch
Status: REOPENED
Product: OMP
Classification: Unclassified
Component: General
1.1.1
All All
: P3 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-22 16:17 PDT by Alec Smecher
Modified: 2014-09-02 15:57 PDT (History)
2 users (show)

See Also:
Version Reported In:
Also Affects:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Smecher 2011-03-22 16:17:57 PDT
"EDITOR NOTE" text hard-coded instead of actual note fetch.
See fixme in code marked against this entry (ReviewerReviewStep1Form).
Comment 1 Juan Pablo Alperin 2011-07-11 23:10:32 PDT

*** This bug has been marked as a duplicate of bug 6747 ***
Comment 2 Alec Smecher 2014-08-26 15:48:59 PDT
This hasn't actually been fixed -- re-opening.
Comment 3 Jason Nugent 2014-09-02 07:25:16 PDT
Alec, the line in the form class:

$templateMgr->assign('reviewerRequest', __('reviewer.step1.requestBoilerplate', $reviewerRequestParams));

Assigns parameters to that locale key, but the locale key does not actually use them.  We can probably just delete the entire $reviewRequestParams array creation on the line above and close the bug, unless I am missing something obvious.
Comment 4 Alec Smecher 2014-09-02 15:57:07 PDT
I haven't ever seen that stuff get used in the interface, so I suspect you're right.