Bug 6506 - Review absolute due date always set to today
Review absolute due date always set to today
Status: RESOLVED FIXED
Product: OCS
Classification: Unclassified
Component: Review
2.3.4
All All
: P3 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-16 05:41 PDT by chakkapas
Modified: 2011-08-16 10:35 PDT (History)
1 user (show)

See Also:
Version Reported In:
Also Affects:


Attachments
A patch for review absolute date problem for OCS 2.3.3-1 (1.34 KB, patch)
2011-03-16 05:41 PDT, chakkapas
Details | Diff
Patch against OCS 2.3.3-1 (1.13 KB, patch)
2011-08-16 10:28 PDT, Michael Felczak
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chakkapas 2011-03-16 05:41:25 PDT
Created attachment 3466 [details]
A patch for review absolute date problem for OCS 2.3.3-1

When setting Peer Review's due date under scheduled conference / settings / review
menu, if we use absolute date rather than number of weeks it always set the due date
back to today when a track director assigning a reviewer.

---

I found that under class TrackDirector::addReviewer when passing $dueDate parameter
to ::setDueDate, it doesn't pass as a string. The value stored in database table
sched_conf_settings as a date time string, when reading back with $schedConf->getSetting
it returns a long integer.
Comment 1 Michael Felczak 2011-08-16 10:27:48 PDT
Thanks chakkapas for all of the details.
Comment 2 Michael Felczak 2011-08-16 10:28:17 PDT
Created attachment 3614 [details]
Patch against OCS 2.3.3-1
Comment 3 Michael Felczak 2011-08-16 10:30:02 PDT
Review absolute due date always set to today
https://github.com/pkp/ocs/commit/58292da6da3e5eb4f60689ebc5f7fab1796a9e60
Comment 4 Michael Felczak 2011-08-16 10:35:01 PDT
Review absolute due date always set to today
https://github.com/pkp/ocs/commit/1e632003af7ca6c1eebd2b288aa123d4a8ec6c45
Comment 5 Michael Felczak 2011-08-16 10:35:56 PDT
Fixed.