Bug 6475 – Problem sorting Custom Review Form elements

Bug 6475 - Problem sorting Custom Review Form elements

Summary:

Problem sorting Custom Review Form elements

Status:	RESOLVED FIXED

Product:	OJS
Classification:	Unclassified
Component:	Journal Management
Version:	2.3.5
Platform:	All All

Importance:	P3 normal
Assigned To:	PKP Support

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-03-04 14:19 PST by James MacGregor
Modified:	2011-03-08 15:45 PST (History)
CC List:	1 user (show)

See Also:
Version Reported In:	2.2.4, 2.3.4
Also Affects:	OCS 2.3.2, OJS 2.2.5

Attachments
Patch against OJS 2.3.3-3 / 2.3.4 (4.97 KB, patch) 2011-03-04 15:46 PST, Alec Smecher	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description James MacGregor 2011-03-04 14:19:48 PST

In OJS 2.3.4: 

If I try and move form elements up and down (eg. from http://git/ojs/index.php/citation/manager/reviewFormElements/4), I receive a blank page/the following error: 

[Fri Mar 04 14:11:55 2011] [error] [client 127.0.0.1] NOTICE: Undefined variable: direction (/Users/jmacgreg/git/ojs/pages/manager/ReviewFormHandler.inc.php:517), referer: http://git/ojs/index.php/citation/manager/reviewFormElements/4

When I return to the previous page, the form element order has not changed. 

In OJS 2.2.4: 

If I try and move form elements up and down, the page refreshes, but there is no change. No blank page, nothing in the logs to indicate an error.

Comment 1 Alec Smecher 2011-03-04 15:46:29 PST

Created attachment 3446 [details]
Patch against OJS 2.3.3-3 / 2.3.4

Comment 2 Alec Smecher 2011-03-04 15:46:36 PST

Fixed.

Comment 3 Alec Smecher 2011-03-08 15:45:56 PST

(Committed to ojs-stable-2_3)