Bug 6409 – PromoteForm and NewReviewRound form need the reviewType

Bug 6409 - PromoteForm and NewReviewRound form need the reviewType

Summary:

PromoteForm and NewReviewRound form need the reviewType

Status:	RESOLVED INVALID

Product:	OMP
Classification:	Unclassified
Component:	General
Version:	1.0
Platform:	PC Linux

Importance:	P3 normal
Assigned To:	PKP Support

URL:

Depends on:
Blocks:	6410
	Show dependency tree / graph

Reported:	2011-02-14 16:36 PST by jerico
Modified:	2011-07-10 14:37 PDT (History)
CC List:	1 user (show)

See Also:
Version Reported In:
Also Affects:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description jerico 2011-02-14 16:36:53 PST

The grids in promoteForm.tpl and newReviewRound.tpl rely on reviewType to retrieve their data. I'd removed that based on the assumption that #6129 would remove review type altogether and only rely on review round + workflow stage. Now it's the other way round, so we either need to base everything off workflow stages or we need to consistently maintain review rounds everywhere.

Comment 1 Juan Pablo Alperin 2011-07-10 14:37:55 PDT

that assumption is correct. It will be based on stageId and round.