Bug 6408 - Break ArticleFile > SuppFile inheritance hierarchy
Break ArticleFile > SuppFile inheritance hierarchy
Status: NEW
Product: OJS
Classification: Unclassified
Component: General
2.4.x
All All
: P3 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-14 15:54 PST by Alec Smecher
Modified: 2012-09-21 14:21 PDT (History)
1 user (show)

See Also:
Version Reported In:
Also Affects:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Smecher 2011-02-14 15:54:15 PST
Supplementary files and SubmissionFile both implement get/setType with different semantic meanings.
Comment 1 Alec Smecher 2011-02-14 16:14:50 PST
Supplementary Files (a logical entity) should not inherit from ArticleFile (a concrete FS resource).
Comment 2 jerico 2011-02-14 16:48:24 PST
For reference: a few ideas in gliffy (to be ported to the Wiki, too): http://www.gliffy.com/gliffy/#d=2317453&t=SubmissionFilesGridHandler (scroll down to see the current file implementations across all apps and a few comments/ideas for potential improvements - all of them not very well thought out yet, just brainstorming).

@Alec: What do you mean by "logical entity"? Aren't supp files the files uploaded during submission as "attachments" to the main article? These would then also be concrete FS resources that go through editing and can be downloaded from the article page... I'm not sure whether I understand that distinction correctly, though. I like the OMP way in this case where all submission files are essentially the same in the editing process only distinguished by genre. Could that be a pattern to be applied to OJS submission files too? Then we could get rid of the distinction between ArticleFile and SuppFile...