PKP Bugzilla – Bug 6244
Remove either the review type or have a single review workflow step.
Last modified: 2011-12-13 12:05:02 PST
We currently have both, two workflow step constants for the review process and the review type field in the monograph. This is redundant information, creates code duplication and an unnecessary potential for inconsistent data and error. We should either remove the distinction between the two WORKFLOW_STAGE_* variables or remove the review type field then.
Current bugs caused by this inconsistency:
- workflow stage policies have WORKFLOW_STAGE_ID_REVIEW_INTERNAL hard coded
- a unique mapping from file stages to workflow stages is not possible (e.g. required for authorization of files) which means that file access can not be correctly authorized
Make sure that stage assignments in setup and default signoffs (stage participants) are compatible with the chosen solution.
Consider removing review type completely and count review rounds from 1 to n across both internal and external review and retrieve the review type passing by file -> submission -> workflow stage and leave the two different workflow stages in there.
added some fixmes where the internal review is hardcoded:
File related grids:
files grid fallback on request var for stageId and data providers always get stageId from containing grid.
Removed old FIXME