PKP Bugzilla – Bug 6071
Duplicate "crossref" plugins create conflicts
Last modified: 2011-02-09 16:34:33 PST
There are several plugins named "crossref" in their version.xml descriptors. This will cause conflicts, i.e. the addPluginVersions code in classes/install/Upgrade.inc.php doesn't appear to discriminate based on category. Running addPluginVersions causes the following message to appear:
You are trying to downgrade the product "crossref" from version [220.127.116.11] to version [18.104.22.168]. Downgrades are not supported.
Florian, a potentially related problem: now that OJS 2.3.3 is out, running tools/upgrade.php will no longer trigger addPluginVersions to be executed. AFAIK, this leaves us without a way to get new plugins entered into the versions table.
The addPluginVersions() problem has been reported in bug #6076. See there. The duplicate crossref version entries problem will be solved here.
I think it's not necessary to have unique product (=plug-in) names across all categories as we include the category name in the plug-in class and therefore shouldn't get duplicate class names. Do you see any problem with having the same plug-in name in two different categories? If not, I'll change VersionDAO to check the category name also.
Florian, that sounds fine to me.
Missed something in the VersionDAO and forgot to migrate a few loc to ocs, ohs and omp, see:
And one in lib-pkp also https://github.com/pkp/pkp-lib/commit/0e874bb4b5d76b5db8ab5cf4f622f51b19c2ed9f