PKP Bugzilla – Bug 6071
Duplicate "crossref" plugins create conflicts
Last modified: 2011-02-09 16:34:33 PST
There are several plugins named "crossref" in their version.xml descriptors. This will cause conflicts, i.e. the addPluginVersions code in classes/install/Upgrade.inc.php doesn't appear to discriminate based on category. Running addPluginVersions causes the following message to appear: You are trying to downgrade the product "crossref" from version [1.1.0.0] to version [1.0.0.0]. Downgrades are not supported.
Florian, a potentially related problem: now that OJS 2.3.3 is out, running tools/upgrade.php will no longer trigger addPluginVersions to be executed. AFAIK, this leaves us without a way to get new plugins entered into the versions table.
The addPluginVersions() problem has been reported in bug #6076. See there. The duplicate crossref version entries problem will be solved here.
I think it's not necessary to have unique product (=plug-in) names across all categories as we include the category name in the plug-in class and therefore shouldn't get duplicate class names. Do you see any problem with having the same plug-in name in two different categories? If not, I'll change VersionDAO to check the category name also.
Florian, that sounds fine to me.
Fixed, see http://github.com/pkp/pkp-lib/commit/74c052f307ac081fe5bee291e72d0abffe3082b7 http://github.com/pkp/ocs/commit/f5c9070e3d0d75379eccc10ba44bbbcafcf00e26 http://github.com/pkp/harvester/commit/109355420cc54f5ea0cbf985600e2c07b0953e8f http://github.com/pkp/ojs/commit/b84992ba2d818f5850db118571653674d0b86c24 http://github.com/pkp/omp/commit/26bb991d599f6a61e382206c8432d1bcc589d337
Missed something in the VersionDAO and forgot to migrate a few loc to ocs, ohs and omp, see: https://github.com/pkp/ocs/commit/354be8ee290323cfc78f89febb779bdfae849bd9 https://github.com/pkp/harvester/commit/100c5c28bcf4f47ae779b2b9c81eec12216d0f10 https://github.com/pkp/ojs/commit/536a95b087301e599c8c95e915e7c723930bd48f https://github.com/pkp/omp/commit/d22e9eba6ee0ab0881a5fd282afddd76b97c3f20
And one in lib-pkp also https://github.com/pkp/pkp-lib/commit/0e874bb4b5d76b5db8ab5cf4f622f51b19c2ed9f