Bug 5918 - ASCII-encoded nbsp appears in fr_CA
ASCII-encoded nbsp appears in fr_CA
Status: RESOLVED FIXED
Product: OJS
Classification: Unclassified
Component: Localization
2.3.3
PC Mac OS X 10.6
: P5 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-21 10:02 PDT by James MacGregor
Modified: 2011-09-13 15:23 PDT (History)
1 user (show)

See Also:
Version Reported In:
Also Affects:


Attachments
Patch against OCS 2.3.3-1 (1.19 KB, patch)
2011-09-13 15:23 PDT, James MacGregor
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James MacGregor 2010-09-21 10:02:29 PDT
There are numerous appearances of   (a non-breaking space/nbsp) in the French locale files. I think these can be replaced by just a space. They are a problem eg. in email being sent out as plaintext. Alec, is this ok? Also, might be worth scanning the locale files for other ASCII-encoded text.
Comment 1 Alec Smecher 2010-09-21 11:30:00 PDT
Yes, that sounds fine to me, James. It should be reasonably straight forward to put together a regexp to look for entities, i.e. "&[#a-zA-Z]{1,8};" -- they should never appear in emails, unless I'm forgetting something major.
Comment 2 James MacGregor 2010-09-21 13:58:56 PDT
(In reply to comment #1)
> Yes, that sounds fine to me, James. It should be reasonably straight forward to
> put together a regexp to look for entities, i.e. "&[#a-zA-Z]{1,8};" -- they
> should never appear in emails, unless I'm forgetting something major.

Thanks, Alec, replaced with a space across the board -- see 

http://github.com/pkp/ojs/commit/ae5ebddb9bd5a28ca4d2af0c912868c7461546b2 and http://github.com/pkp/ojs/commit/5ef9b97de4ee407025c9dc4450992cd4be464459 for OJS;

http://github.com/pkp/ocs/commit/29bdd91101908d490892bdee69a8e0b969814440 for OCS; 

It doesn't appear that that entity exists in lib/pkp. 

I don't see any other instances of other weird ASCII in the email files.
Comment 3 James MacGregor 2011-09-13 15:23:30 PDT
Created attachment 3638 [details]
Patch against OCS 2.3.3-1