Bug 5373 - Fatal error: ReviewAssignmentDAO::updateObject()
Fatal error: ReviewAssignmentDAO::updateObject()
Status: RESOLVED FIXED
Product: OCS
Classification: Unclassified
Component: General
2.3.1
All All
: P2 major
Assigned To: PKP Support
http://pkp.sfu.ca/support/forum/viewt...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-28 00:48 PDT by ponsfrilus
Modified: 2010-04-28 09:52 PDT (History)
2 users (show)

See Also:
Version Reported In: 2.3.1
Also Affects:


Attachments
Patch against OCS 2.3.1 (877 bytes, patch)
2010-04-28 09:52 PDT, Alec Smecher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ponsfrilus 2010-04-28 00:48:48 PDT
Happens when trying to update/create a custom review form:

Fatal error: Call to undefined method ReviewAssignmentDAO::updateObject() in /var/www/ocs23/classes/submission/form/ReviewFormResponseForm.inc.php on line 96

Call Stack
#	Time	Memory	Function	Location
1	0.0001	110256	{main}( )	../index.php:0
2	0.0439	7669608	PKPApplication->execute( )	../index.php:65
3	0.0457	8168288	Dispatcher->dispatch( )	../PKPApplication.inc.php:170
4	0.0984	14097440	PKPPageRouter->route( )	../Dispatcher.inc.php:130
5	0.1043	14959488	SubmissionReviewHandler->saveReviewFormResponse( )	../PKPPageRouter.inc.php:177
6	0.1043	14960136	ReviewerAction->saveReviewFormResponse( )	../SubmissionReviewHandler.inc.php:219
7	0.1164	16315936	ReviewFormResponseForm->execute( )	../ReviewerAction.inc.php:361



Change /ocs/classes/submission/form/ReviewFormResponseForm.inc ligne 96 from
CODE: SELECT ALL
      $reviewAssignmentDao->updateObject($reviewAssignment);
to
CODE: SELECT ALL
      $reviewAssignmentDao->updateReviewAssignment($reviewAssignment);


The function updateObject() does not exist in /ocs/classes/submission/reviewAssignment/ReviewAssignmentDAO.inc
ponsfrilus
 

Also posted in ocs forum: http://pkp.sfu.ca/support/forum/viewtopic.php?f=3&t=6055
Comment 1 Alec Smecher 2010-04-28 09:09:41 PDT
Thanks for contributing, ponsfrilus -- that fix is correct. (We'll be updating method calls called updateSomeObjectName to updateObject, however this one was accidentally done incompletely.)
Comment 2 ponsfrilus 2010-04-28 09:29:33 PDT
Alec,
  if I remember well there is a second call of this method in this file.
Comment 3 Alec Smecher 2010-04-28 09:44:15 PDT
Hi ponsfrilus -- There's a call to ReviewFormResponseDao::updateObject in the same file, but that function is indeed defined.
Comment 4 Alec Smecher 2010-04-28 09:52:13 PDT
Created attachment 3086 [details]
Patch against OCS 2.3.1
Comment 5 Alec Smecher 2010-04-28 09:52:39 PDT
Comment on attachment 3086 [details]
Patch against OCS 2.3.1

Oops -- wrong entry.