Bug 5217 – Comment comment_title too short; can lead to DB error

Bug 5217 - Comment comment_title too short; can lead to DB error

Summary:

Comment comment_title too short; can lead to DB error

Status:	RESOLVED FIXED

Product:	OJS
Classification:	Unclassified
Component:	General
Version:	2.3.3
Platform:	PC Linux

Importance:	P5 enhancement
Assigned To:	Alec Smecher

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-03-15 08:13 PDT by Alec Smecher
Modified:	2010-03-16 07:34 PDT (History)
CC List:	2 users (show)

See Also:
Version Reported In:
Also Affects:

Attachments
For 2.3.2 (4.29 KB, patch) 2010-03-16 06:05 PDT, Tom Christensen	Details \| Diff
Full fix for 2.2.4 (7.63 KB, patch) 2010-03-16 06:07 PDT, Tom Christensen	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alec Smecher 2010-03-15 08:13:00 PDT

Comment comment_title too short; can lead to DB error.

Comment 1 Alec Smecher 2010-03-15 08:23:39 PDT

http://github.com/pkp/ojs/commit/5e8547273b8679c2c7f306982159ae9d661ca2ac

Comment 2 Tom Christensen 2010-03-16 06:01:35 PDT

The patch seems incomplete and inconsistent.

I does not update the templates and code that handles article_comments.comment_title only the code and templates handling comments.title.

Comment 3 Tom Christensen 2010-03-16 06:05:17 PDT

Created attachment 3050 [details]
For 2.3.2

Fixes inconsistency in the original patch.

Comment 4 Tom Christensen 2010-03-16 06:07:25 PDT

Created attachment 3051 [details]
Full fix for 2.2.4

A complete fix for bz5217 in the 2.2.x branch.

Comment 5 Alec Smecher 2010-03-16 06:58:48 PDT

Tom, the "comments" and "article_comments" tables are related to different features; I'll fix them in separate Bugzilla entries (see bug #5199).

Comment 6 Tom Christensen 2010-03-16 07:34:48 PDT

I know they're different features and I was not aware of bz#5199 but it is the exact problem I attempted to report in the forum (http://pkp.sfu.ca/support/forum/viewtopic.php?f=8&t=5877).
But unless I'm completely misreading your patch (which is certainly possible) you seem to update the column for one feature (article_comments.comment_title) but fixed the templates and code for a different one (comments.title) hence my confusion.