Bug 4772 - Review & correct problems in the warning log
Review & correct problems in the warning log
Status: RESOLVED FIXED
Product: PKP-LIB
Classification: Unclassified
Component: General
2.0
PC Linux
: P5 enhancement
Assigned To: Alec Smecher
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-22 11:34 PDT by Alec Smecher
Modified: 2009-10-06 15:07 PDT (History)
1 user (show)

See Also:
Version Reported In:
Also Affects:


Attachments
Patch against OJS pre-2.3 CVS (34.78 KB, patch)
2009-09-22 11:38 PDT, Alec Smecher
Details | Diff
Patch against PKP pre-release (5.28 KB, patch)
2009-09-22 11:38 PDT, Alec Smecher
Details | Diff
Patch against OMP pre-release (79.96 KB, patch)
2009-09-22 12:21 PDT, Alec Smecher
Details | Diff
Patch against Harvester 2.3 (1.33 KB, patch)
2009-09-22 12:24 PDT, Alec Smecher
Details | Diff
Patch against PKP pre-release (11.52 KB, patch)
2009-09-22 14:19 PDT, Alec Smecher
Details | Diff
Patch against OJS pre-2.3 CVS (81.43 KB, patch)
2009-09-22 14:20 PDT, Alec Smecher
Details | Diff
Patch against OMP pre-release (52.40 KB, patch)
2009-09-22 14:27 PDT, Alec Smecher
Details | Diff
Patch against OCS pre-2.3 CVS (73.78 KB, patch)
2009-09-22 14:27 PDT, Alec Smecher
Details | Diff
Patch against Harvester 2.3 (17.80 KB, patch)
2009-09-22 14:28 PDT, Alec Smecher
Details | Diff
Patch against PKP pre-release (1.42 KB, patch)
2009-10-06 13:56 PDT, Alec Smecher
Details | Diff
Patch against OJS pre-2.3 CVS (9.32 KB, patch)
2009-10-06 13:59 PDT, Alec Smecher
Details | Diff
Patch against OCS pre-2.3 CVS (16.06 KB, patch)
2009-10-06 14:46 PDT, Alec Smecher
Details | Diff
Patch against Harvester 2.3 (4.68 KB, patch)
2009-10-06 15:07 PDT, Alec Smecher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Smecher 2009-09-22 11:34:46 PDT
Review & correct problems in the warning log. For example:
 - There are still some unnecessary cases of instantiation by reference (=& new)
 - There is a warning about get_class being called by a non-object in GenericCache.inc.php (probably needs an is_object check)
Comment 1 Alec Smecher 2009-09-22 11:38:11 PDT
Created attachment 2453 [details]
Patch against OJS pre-2.3 CVS
Comment 2 Alec Smecher 2009-09-22 11:38:39 PDT
Created attachment 2454 [details]
Patch against PKP pre-release
Comment 3 Alec Smecher 2009-09-22 12:21:43 PDT
Created attachment 2455 [details]
Patch against OMP pre-release
Comment 4 Alec Smecher 2009-09-22 12:24:00 PDT
Created attachment 2456 [details]
Patch against Harvester 2.3
Comment 5 Alec Smecher 2009-09-22 14:19:02 PDT
Created attachment 2457 [details]
Patch against PKP pre-release
Comment 6 Alec Smecher 2009-09-22 14:20:07 PDT
Created attachment 2458 [details]
Patch against OJS pre-2.3 CVS
Comment 7 Alec Smecher 2009-09-22 14:27:07 PDT
Created attachment 2459 [details]
Patch against OMP pre-release
Comment 8 Alec Smecher 2009-09-22 14:27:35 PDT
Created attachment 2460 [details]
Patch against OCS pre-2.3 CVS
Comment 9 Alec Smecher 2009-09-22 14:28:43 PDT
Created attachment 2461 [details]
Patch against Harvester 2.3
Comment 10 Alec Smecher 2009-09-22 16:57:33 PDT
Closing.
Comment 11 Alec Smecher 2009-10-06 13:56:05 PDT
Created attachment 2491 [details]
Patch against PKP pre-release

Re-added some necessary reference instantiation (for FormValidatorCustom instantiations that use &$this from form constructors)
Comment 12 Alec Smecher 2009-10-06 13:59:07 PDT
Created attachment 2492 [details]
Patch against OJS pre-2.3 CVS
Comment 13 Alec Smecher 2009-10-06 14:46:06 PDT
Created attachment 2494 [details]
Patch against OCS pre-2.3 CVS
Comment 14 Alec Smecher 2009-10-06 15:07:31 PDT
Created attachment 2495 [details]
Patch against Harvester 2.3