Bug 4768 – changing the order of a journal does nothing

Bug 4768 - changing the order of a journal does nothing

Summary:

changing the order of a journal does nothing

Status:	RESOLVED FIXED

Product:	OJS
Classification:	Unclassified
Component:	Site
Version:	2.3
Platform:	All All

Importance:	P5 normal
Assigned To:	Alec Smecher

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-09-21 15:17 PDT by Colin Prince
Modified:	2009-09-21 15:32 PDT (History)
CC List:	1 user (show)

See Also:
Version Reported In:
Also Affects:

Attachments
Patch against OJS pre-2.3 CVS (1.12 KB, text/plain) 2009-09-21 15:31 PDT, Alec Smecher	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Colin Prince 2009-09-21 15:17:02 PDT

I got a blank screen.

Looking at the code this seems to expect 'journalId' not just 'id' on line 132 of pages/admin/AdminJournalHandler.inc.php

No problem changing it back but mystified as to why this was changed in the first place:

http://pkp.sfu.ca/cvs/cvsweb.cgi/ojs2/pages/admin/AdminJournalHandler.inc.php?rev=1.33;content-type=text%2Fx-cvsweb-markup

Comment 1 Alec Smecher 2009-09-21 15:31:01 PDT

Created attachment 2451 [details]
Patch against OJS pre-2.3 CVS

Comment 2 Alec Smecher 2009-09-21 15:32:11 PDT

This change was made to permit drag 'n' drop rearrangement of lists (bug #4010). You'll have to enable the JQuery plugin in order for this to work:

insert into plugin_settings (plugin_name, journal_id, setting_name, setting_value, setting_type) values ('JQueryPlugin', 0, 'enabled', 1, 'bool');