Bug 4474 - put static pages and custom block manager plugins into CVS
put static pages and custom block manager plugins into CVS
Status: RESOLVED FIXED
Product: OCS
Classification: Unclassified
Component: General
2.3
PC Mac OS X 10.3
: P5 enhancement
Assigned To: Ryan Yeske
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-24 17:03 PDT by Juan Pablo Alperin
Modified: 2009-10-22 11:09 PDT (History)
3 users (show)

See Also:
Version Reported In:
Also Affects:


Attachments
port of custom block manager plugin from ojs to ocs (21.71 KB, patch)
2009-10-17 00:21 PDT, Ryan Yeske
Details | Diff
unified diff (15.84 KB, patch)
2009-10-17 00:26 PDT, Ryan Yeske
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Juan Pablo Alperin 2009-06-24 17:03:14 PDT
Perhaps even into the core, although this might require more abstraction work.  If not, just putting both into CVS and officially supporting them would be good.
Comment 1 Juan Pablo Alperin 2009-07-22 12:29:06 PDT
static pages put into both OCS/OJS.  Custom Block manager into OJS.  

Work done on OJS 2.3.

Still need to do customBlockManager port for OCS.
Comment 2 Juan Pablo Alperin 2009-07-22 18:12:13 PDT
moving to OCS to clear off plate from OJS 2.3 release
Comment 3 Ryan Yeske 2009-10-17 00:21:52 PDT
Created attachment 2536 [details]
port of custom block manager plugin from ojs to ocs

I ported this plugin over from ojs2 following the pattern I found in the static pages plugin port.  Aside from substituting journalId with conferenceId, there is an additional 'schedConfId' added to the {get,set,delete}Setting calls (it is 0 in all cases, is this correct?).

Enabling, disabling the plugin, along with adding, editing and deleting block plugins is tested and works the same way as in ojs.
Comment 4 Ryan Yeske 2009-10-17 00:26:36 PDT
Created attachment 2537 [details]
unified diff

Replaced context diff with unified diff
Comment 5 Alec Smecher 2009-10-19 19:01:57 PDT
Looks good to me, Ryan; go ahead and commit and close.
Comment 6 Ryan Yeske 2009-10-22 11:09:19 PDT
Commit