PKP Bugzilla – Bug 3806
Add a la carte items to registration
Last modified: 2009-02-24 09:19:25 PST
Add a la carte items to registration.
Created attachment 1039 [details] Patch against OCS pre-2.1.2 CVS
in this file: classes/registration/RegistrationOptionDAO.inc.php line 218 has field count of 7 and line 220 has value count of 6. perhaps we should take out "currency_code_alpha" from the fields row.
Created attachment 1046 [details] Patch against OCS pre-2.1.2 CVS I made the correction Siavash noted in the previous comment and two other very minor changes: -userRegistrationForm.tpl had an open <label> tag -I added a "cost" field to the "Create New Registration Option" that gives an explanation (saying costs must be set in the registration type. Of course, new Locale key for this also. I should note that in the future it might be nice to allow for registration options to be enabled/disabled per registration type. i.e. perhaps not all options should be available for application types. This can be solved by putting a checkbox next to the cost in the registration type edit page. However, I think this is a good start and we can start using it for the PKP conference.
The registration options chosen by the registrant do not appear in the Registration Report (under Stats & Reports).
Created attachment 1047 [details] Patch against OCS pre-2.1.2 CVS Patch solves various other bugs found: - price was not being set properly for registration type + options chosen - added .00 to prices (not $, as this is not convention followed to be flexible for multiple currencies) - dates now allow up to +10 years still pending: comment #4 - I haven't touched reporting yet, but everything seems to be recorded correctly in database for now, at least.
*** Bug 3826 has been marked as a duplicate of this bug. ***
*** Bug 3827 has been marked as a duplicate of this bug. ***
*** Bug 3829 has been marked as a duplicate of this bug. ***
Patch worked fine. However, your patch removes the template config file (config.TEMPLATE.inc.php). Is that needed? Perhaps that should be taken out of the patch?
Created attachment 1056 [details] supplement to OCS patch patch for OCS did not include a patch of the ReviewFormHandler which was added at almost the same time as original patch
Comment on attachment 1056 [details] supplement to OCS patch Wrong bug
When trying to enroll an existing user to a registration, I am getting the following error: Warning: in_array() [function.in-array]: Wrong datatype for second argument in /Users/juan/Code/ocs-base/cache/t_compile/%%02^028^0283A393%%registrationForm.tpl.php on line 72 type="checkbox" name="registrationOptionIds[]" value="1]"/> Banquet At URL: http://dev.ocs.local/index.php/ocs-dev/pkp2009/manager/createRegistration?userId=1
Created attachment 1062 [details] Patch against OCS pre-2.2 (or is going to be called 2.3?) CVS Development patch does NOT contain the locale changes. Locale changes related to this patch can be found in Attachment #1061 [details] in bug #1444.
Created attachment 1070 [details] in_array error: OCS pre 2.3 CVS Patch to resolve error described in attachment #12 [details]. If you want to fix this in our PKP conference install, simply change (in line 52): {if in_array($optionId, $registrationOptionIds)} to {if $registrationOptionIds && in_array($optionId, $registrationOptionIds)}
last message should have read comment #12, not attachment #12 [details].
Juan, does this need to be fixed in the PKP conference install, and has someone taken care of it?
re: comment #14 This needs to be fixed in the PKP conference install. Kevin probably hasn't come across it because it only appears when you try to create a new registration without the user having previously tried to sign himself up.
Patched pkp 2009 install as per comment #17.
Created attachment 1075 [details] Registrant Report Patch: against PKP 2009 install OCS 2.1.1 Alec or Siavash, can you apply this patch to the registrant report on the PKP install? I will post another patch for the dev branch. This one is against my patched 2.1.1.
Created attachment 1076 [details] Registrant Report Patch: against pre 2.3 CVS committed this patch to pre-2.3 CVS
Patched the PKP install.
committed to OCS-stable branch (including comment #12 and registration report)
Juan, what remains to be done on this entry?
it needed to be closed. :)