PKP Bugzilla – Bug 3796
Creating a New Section fails when "None/ Free From Review" Review Form is chosen
Last modified: 2008-10-02 09:08:15 PDT
From Journal Management --> Journal Section --> Create Section If no Review Form is chosen then, clicking Save will cause a database error on Windows version of MySQL. This is because it is attempting to insert an empty string into the 'review_form_id' database column on the sections table. If no review form is chosen it should insert a null. I fixed the code on our site by adding the following at lines 214: Old code (Line 214) $section->setReviewFormId($this->getData('reviewFormId')); New code: if ($this->getData('reviewFormId') != '') { $section->setReviewFormId($this->getData('reviewFormId')); } else { $section->setReviewFormId(null); } I'm sure there are better ways of doing this but its done the trick for us. Thanks Mick Equinox Journals Science Registry
My apologies, should have also mentioned that the PHP file changed was SectionForm.inc.php in classes/manager/form
*** This bug has been marked as a duplicate of bug 3790 ***
Created attachment 999 [details] diff file which corrects problem in bug 3790 but DOES allow section editors to be added in create phase. My only thoughts were that it would be good to keep the section editors available during the creation of a journal section. I did this by always initialising the 'unassignedEditors' information. I have included a diff file for inspection.
Good point, Michael -- I've moved that change over to bug #3790 and committed it there. Thanks - Alec *** This bug has been marked as a duplicate of bug 3790 ***