PKP Bugzilla – Bug 3765
Back-port review forms to OCS
Last modified: 2009-02-13 11:03:40 PST
Created attachment 967 [details]
patch against OCS pre-2.1.2 CVS
Created attachment 968 [details]
Patch against OCS Pre-2.3 CVS
Looks great, Matt! I'll wait to commit this until OCS 2.1.1 has been released.
OJS bug #3790 needs to be back-ported once these changes are committed.
(In reply to comment #4)
> OJS bug #3790 needs to be back-ported once these changes are committed.
I'm not getting the same errors as reported in bug 3790 and bug 3796 -- Am I missing something? Does the review form backport fix this problem already (I.e. review_form ids are null by default)? Otherwise I have a backport waiting (I probably should've tried to reproduce the behavior before I did that!).
This should be a fairly straight-across back port -- I believe that only some versions of MySQL complain about it, so that might explain why you're not getting the same problem. It's worth keeping the code synced anyway, even if you can't reproduce the problem.
Created attachment 1013 [details]
Patch against OCS Pre-2.1.2 CVS
Committed attachment #967 [details] and attachment #1013 [details] to OCS2 devel tree.
Bug #3821 needs to be back-ported (locale key changes for review forms).
Bug #3821 back-ported to devel tree.
Review forms not yet committed to stable tree, but everything else is done.
Committed to stable tree (along with Bug #3821).
Matt, can this entry be closed?
I'm going to go with yes.