Bug 7964

Summary: Upgrading 2.3.7 to 2.4.1 does not create the "gifts" table
Product: OJS Reporter: Andrea Azzini <andreazzini>
Component: InstallerAssignee: PKP Support <pkp-support>
Status: RESOLVED FIXED    
Severity: normal CC: jason.nugent, luizborges
Priority: P3    
Version: 2.4.1   
Hardware: All   
OS: All   
Version Reported In: Also Affects:

Description Andrea Azzini 2012-10-16 09:43:12 PDT
I had a 2.3.7 install and I just upgraded it to 2.4.1 via
# php tools/upgrade.php patch
# php tools/upgrade.php upgrade

The resulting database had 114 tables instead of the 115 found in a fresh 2.4.1 install, which hit me when deleting a journal failed with a database error: table "ojs.gifts" does not exist.

So, it appears that such an upgrade will forget to create the "gifts" table.

Unfortunately, at this time I don't have a deep enough knowledge of the OJS upgrade process nor of the XML database schema format you use, for me to narrow down the problem any further.

As a side note, just copying the "gifts" table structure from a fresh 2.4.1 install was a sufficient workaround for deleting the journal.
Comment 1 Jason Nugent 2012-10-16 11:05:02 PDT
include gift schema in upgrade process
https://github.com/pkp/ojs/commit/0ae520b9af8b8e47aad1e09ed457302d47f32936
Comment 2 Jason Nugent 2012-10-16 11:05:02 PDT
include gift schema in upgrade process
https://github.com/pkp/ojs/commit/f154699f1ec770c331244208f58b20e3e1a6b411
Comment 3 Jason Nugent 2012-10-16 11:07:33 PDT
Hi Andrea,

Thanks for the report.  This has been fixed, and a patch for this is available at https://github.com/pkp/ojs/commit/0ae520b9af8b8e47aad1e09ed457302d47f32936.diff

Regards,
Jason
Comment 4 Luiz Borges 2013-01-04 05:57:25 PST
What I'm supposed to do after I apply this patch? Run the upgrade routine again? Will that create any problems?
Comment 5 Jason Nugent 2013-01-04 05:58:33 PST
Hi Luiz,

Yes, you'd have to run the upgrade again.  It should not create any problem.

Regards,
Jason
Comment 6 Luiz Borges 2013-01-04 08:39:03 PST
I run the upgrade, but I noticed that I have 116 tables, instead of the 115 that Andrea mentioned above.

Where can I find the list of all table names of 2.4.1?