Bug 7952

Summary:	More call time pass by reference
Product:	OMP	Reporter:	Alec Smecher <alec>
Component:	General	Assignee:	PKP Support <pkp-support>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	P3
Version:	1.0
Hardware:	All
OS:	All
Version Reported In:		Also Affects:

Description Alec Smecher 2012-10-05 10:10:57 PDT

More cases appear e.g. in PressGridHandler. Find and fix thoroughly.

Comment 1 Alec Smecher 2012-10-05 10:45:03 PDT

More pass by reference
https://github.com/pkp/omp/commit/7c8e8a9977f6c5a11f5e5d54bb427d7544eb321f

Comment 2 Alec Smecher 2012-10-05 10:45:03 PDT

More pass by reference
https://github.com/pkp/omp/commit/46bed2973dfd9c1a1c5fe441c284aa95582ec7cb

Comment 3 Alec Smecher 2012-10-05 10:55:02 PDT

More pass by reference
https://github.com/pkp/pkp-lib/commit/8b6ad140058a7a1d6c01d365161f2ba244c57d6d

Comment 4 Alec Smecher 2012-10-05 10:55:02 PDT

More pass by reference
https://github.com/pkp/ojs/commit/3b34dfb183eb0f311d80cccbd61155fba3a21f76

Comment 5 Alec Smecher 2012-10-05 11:00:03 PDT

More pass by reference
https://github.com/pkp/pkp-lib/commit/a25d5aaf2138ab6b6363f2ffaf30e8afa94a01b5

Comment 6 Alec Smecher 2012-10-05 11:00:03 PDT

More pass by reference
https://github.com/pkp/ojs/commit/c4a48f2c30375d81f32d75392c983b644b285ce4

Comment 7 Alec Smecher 2012-10-05 11:00:03 PDT

More pass by reference
https://github.com/pkp/ojs/commit/56cc7bcf764bbc1e4581ae6074cfab581f7f4ebd

Comment 8 Alec Smecher 2012-10-05 11:05:02 PDT

More pass by reference
https://github.com/pkp/pkp-lib/commit/997c747b71442f09894f789fa17cb5335b4040a2

Comment 9 Alec Smecher 2012-10-05 11:59:51 PDT

Use the following patch for OMP 1.0b:
https://github.com/pkp/omp/commit/7c8e8a9977f6c5a11f5e5d54bb427d7544eb321f

Comment 10 Alec Smecher 2012-10-05 12:00:04 PDT

More pass by reference
https://github.com/pkp/ocs/commit/c590db18725b1793d651a02a9c1d74739b565d8e

Comment 11 Alec Smecher 2012-10-05 12:00:17 PDT

(In reply to comment #9)
> Use the following patch for OMP 1.0b:
> https://github.com/pkp/omp/commit/7c8e8a9977f6c5a11f5e5d54bb427d7544eb321f

Available also as a diff file at https://github.com/pkp/omp/commit/7c8e8a9977f6c5a11f5e5d54bb427d7544eb321f.diff