|
PKP Bugzilla – Full Text Bug Listing |
| Summary: | CrossRef plugin uses incorrect publication date for articles | ||
|---|---|---|---|
| Product: | OJS | Reporter: | James MacGregor <jmacgreg> |
| Component: | Submissions and Publishing | Assignee: | James MacGregor <jmacgreg> |
| Status: | REOPENED --- | ||
| Severity: | normal | CC: | afadel97, alec, bretschneider, pkp-support |
| Priority: | P3 | ||
| Version: | 2.4.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Version Reported In: | Also Affects: | ||
| Attachments: | Patch against OJS pre-2.3.7 | ||
|
Description
James MacGregor
2012-01-16 17:58:30 PST
Created attachment 3695 [details]
Patch against OJS pre-2.3.7
I believe the following simple patch fixes the problem, but since this change affects metadata representation I'd prefer if someone (Alec?) could vet and confirm before I commit.
James, that looks fine to me as long as it's been smoke-tested for typos. Go for it. CrossRef uses incorrect publication date for articles https://github.com/pkp/ojs/commit/e5f419bcbf1f53b1ca4e8ea7ff9605545cf2162e CrossRef plugin uses incorrect publication date for articles https://github.com/pkp/ojs/commit/a1f15f136acf94125e130871b74339555d7eff6c Thanks, Alec! I tested against a devel and production server, and all looks good. (In reply to comment #5) > Thanks, Alec! I tested against a devel and production server, and all looks > good. Hello, I'm afraid, that this patch is not correct. For crossref-data the article publication-date is mandatory but with this fix only a article-publication-date is inserted into Crossref-Export File, if this value is set. There need`s a else condition with $publicationDateNode =& CrossRefExportDom::generatePublisherDateDom($doc, $issue->getDatePublished()); Best regards Katrin Katrin, are you encountering situations where an article is published (i.e. is available on the public website) but this date is not set? (In reply to comment #6) > (In reply to comment #5) > > Thanks, Alec! I tested against a devel and production server, and all looks > > good. > > Hello, > > I'm afraid, that this patch is not correct. For crossref-data the article > publication-date is mandatory but with this fix only a article-publication-date > is inserted into Crossref-Export File, if this value is set. > There need`s a else condition with > $publicationDateNode =& CrossRefExportDom::generatePublisherDateDom($doc, > $issue->getDatePublished()); > > Best regards > Katrin Reopening to investigate further -- we've had another report of this being an issue at http://pkp.sfu.ca/support/forum/viewtopic.php?f=2&t=8492&p=33112#p33112. Deferring. |