Bug 6916

Summary: Multiple listing entries for single paper
Product: OCS Reporter: Michael Felczak <michael.pkp>
Component: EditingAssignee: Michael Felczak <michael.pkp>
Status: RESOLVED FIXED    
Severity: normal CC: alec, pkp-support
Priority: P3    
Version: 2.3.4   
Hardware: All   
OS: All   
Version Reported In: Also Affects: OJS 2.3.7
Attachments: Patch against OCS 2.3.3-1
Patch against OJS 2.3.6

Description Michael Felczak 2011-10-06 10:05:38 PDT
Courtesy of:
http://pkp.sfu.ca/support/forum/viewtopic.php?f=3&t=7938
Comment 1 Michael Felczak 2011-10-06 10:06:22 PDT
Primary author appears to be set for more than one author.
Comment 2 Michael Felczak 2011-10-06 10:26:38 PDT
The following will result in the primary contact field being set for multiple authors:

- Save paper metadata with only one author.
- Edit paper metadata, add second author and designate as primary contact
Comment 3 Michael Felczak 2011-10-06 10:28:59 PDT
Likely affects OJS as well.
Comment 4 Michael Felczak 2011-10-06 21:45:01 PDT
Multiple listing entries for single paper
https://github.com/pkp/ocs/commit/1add0a4e34198bc2d76fad518000d0cf41166a98
Comment 5 Michael Felczak 2011-10-06 21:47:07 PDT
This was somewhat tricky to debug:
- reference to the first author was not being unset
- second author data overwrote first author data
- second author was inserted into the db
- second author was updated in the db
- first author was never updated
- first author primary contact was never set to 0
Comment 6 Michael Felczak 2011-10-06 21:55:02 PDT
Multiple listing entries for single paper
https://github.com/pkp/ocs/commit/d507def599f3c3bef764b4224c8dbf1898dbd58a
Comment 7 Michael Felczak 2011-10-06 22:00:02 PDT
Multiple listing entries for single article
https://github.com/pkp/ojs/commit/4d4eda3efc53f5c7631fd7cb08a84ec38a9cd0e3
Comment 8 Michael Felczak 2011-10-06 22:00:02 PDT
Multiple listing entries for single article
https://github.com/pkp/ojs/commit/568841b67115b12cf5bded41b22761db91ef2760
Comment 9 Michael Felczak 2011-10-06 22:00:12 PDT
Created attachment 3653 [details]
Patch against OCS 2.3.3-1
Comment 10 Michael Felczak 2011-10-06 22:01:22 PDT
Created attachment 3654 [details]
Patch against OJS 2.3.6
Comment 11 Michael Felczak 2011-10-06 22:04:53 PDT
To restore a paper/article that is being displayed multiple times in a Director/Editor listing:

- apply the patch to your install
- edit the paper/article metadata
- save the paper/article metadata

This should reset the primary contact field so that it's set for only one author.
Comment 12 Michael Felczak 2011-10-06 22:05:17 PDT
Fixed.
Comment 13 Alec Smecher 2011-10-07 09:02:49 PDT
Good catch -- those reference glitches are tricky.