We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.

Bug 6915

Summary: Review due date incorrectly set and displayed for paper review
Product: OCS Reporter: Michael Felczak <michael.pkp>
Component: ReviewAssignee: Michael Felczak <michael.pkp>
Status: REOPENED ---    
Severity: normal CC: alec, pkp-support
Priority: P3    
Version: 3.x   
Hardware: All   
OS: All   
Version Reported In: Also Affects:
Attachments: Screenshots with additional details
Patch against OCS 2.3.3-1

Description Michael Felczak 2011-10-06 09:19:58 PDT
On Director's submission review page.

Please see attachment for additional details.

Courtesy of:
http://pkp.sfu.ca/support/forum/viewtopic.php?f=3&t=7887&p=30921#p30911
Comment 1 Michael Felczak 2011-10-06 09:20:57 PDT
Created attachment 3651 [details]
Screenshots with additional details
Comment 2 Michael Felczak 2011-10-07 16:34:41 PDT
For 2-stage review, after abstract review is completed and reviewer assignments from abstract review are set as defaults for paper review.
Comment 3 Michael Felczak 2011-10-07 16:40:02 PDT
Review due date incorrectly set and displayed for paper review
https://github.com/pkp/ocs/commit/24feaba7fd52ffa317cb6ce82a3e3bd7776c642e
Comment 4 Michael Felczak 2011-10-07 16:42:41 PDT
Created attachment 3655 [details]
Patch against OCS 2.3.3-1
Comment 5 Michael Felczak 2011-10-07 16:45:01 PDT
Review due date incorrectly set and displayed for paper review
https://github.com/pkp/ocs/commit/17ac7fcbd5675655207c7247e7f9983a53add33f
Comment 6 Michael Felczak 2011-10-07 16:47:09 PDT
Fixed.
Comment 7 Alec Smecher 2011-10-07 17:04:59 PDT
Michael, I'm confused about this fix -- shouldn't the existing calls to TrackDirectorAction::setDueDate update the due date field?
Comment 8 Michael Felczak 2011-10-07 17:22:13 PDT
This was confusing for me as well. 

Although the due date is initially correctly updated in the db, the review assignment itself in the track submission is not updated with this new date info.

The now-stale track submission is then updated in the db, wiping the previously set due date.
Comment 9 Alec Smecher 2011-10-07 20:46:44 PDT
OK, though the patch is more of a work-around than a fix -- I'd suggest leaving this open for a better clean-up when we get the chance.