|
PKP Bugzilla – Full Text Bug Listing |
| Summary: | New submission notifications not sent to editors | ||
|---|---|---|---|
| Product: | OJS | Reporter: | Matthew Crider <mattcrider> |
| Component: | Editors | Assignee: | PKP Support <pkp-support> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alec |
| Priority: | P3 | ||
| Version: | 2.3.7 | ||
| Hardware: | All | ||
| OS: | All | ||
| Version Reported In: | Also Affects: | ||
| Attachments: |
Patch against OJS 2.3.6
Patch against OJS 2.3.6 |
||
|
Description
Matthew Crider
2011-08-03 13:06:13 PDT
Created attachment 3606 [details]
Patch against OJS 2.3.6
Needs porting to OCS. Also, beware of references -- if you pass the object off to another function it may behave unexpectedly. The best pattern to use is:
while ($object = $iterator->next()) {
// Do something
}
Fix editor list construction for new article notifications https://github.com/pkp/ojs/commit/3d5e0ef8d00e31ae76b16da816e00cbcb9f6098e Fix editor list construction for new article notifications https://github.com/pkp/ojs/commit/4ec1fb590dc5d9eacba6e0ca3890dd8eed68c348 Cleaned up editor selection for new submission notification https://github.com/pkp/ocs/commit/365a4c8f4136385984e33108c6ea80f103456852 Cleaned up editor selection for new submission notification https://github.com/pkp/ocs/commit/d10549d68ee04486e6c6941a42663a4b52fecb7e Cleaned up editor selection for new submission notification https://github.com/pkp/ojs/commit/0aec01b4e9dd90e1b53d9d24b4dc22e05f0e5bcc Created attachment 3607 [details]
Patch against OJS 2.3.6
Attachment #3607 [details] is OK, but in general, beware the reference -- best to use either:
while ($thing =& $iterator->next()) {
// Do something, then...
unset($thing);
}
...or don't use references...
while ($thing = $iterator->next()) {
// Do something
}
Cleaned up editor selection for new submission notification https://github.com/pkp/ojs/commit/6e172849d367481b122d23cea01a96c267ce515c I am unsetting $editor -- its just not in the patch (was already doing it). Great! Didn't see that. Think we're all done here.. |