We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.

Bug 6506

Summary: Review absolute due date always set to today
Product: OCS Reporter: chakkapas <chakkapas.visavakul>
Component: ReviewAssignee: PKP Support <pkp-support>
Status: RESOLVED FIXED    
Severity: normal CC: michael.pkp
Priority: P3    
Version: 2.3.4   
Hardware: All   
OS: All   
Version Reported In: Also Affects:
Attachments: A patch for review absolute date problem for OCS 2.3.3-1
Patch against OCS 2.3.3-1

Description chakkapas 2011-03-16 05:41:25 PDT
Created attachment 3466 [details]
A patch for review absolute date problem for OCS 2.3.3-1

When setting Peer Review's due date under scheduled conference / settings / review
menu, if we use absolute date rather than number of weeks it always set the due date
back to today when a track director assigning a reviewer.

---

I found that under class TrackDirector::addReviewer when passing $dueDate parameter
to ::setDueDate, it doesn't pass as a string. The value stored in database table
sched_conf_settings as a date time string, when reading back with $schedConf->getSetting
it returns a long integer.
Comment 1 Michael Felczak 2011-08-16 10:27:48 PDT
Thanks chakkapas for all of the details.
Comment 2 Michael Felczak 2011-08-16 10:28:17 PDT
Created attachment 3614 [details]
Patch against OCS 2.3.3-1
Comment 3 Michael Felczak 2011-08-16 10:30:02 PDT
Review absolute due date always set to today
https://github.com/pkp/ocs/commit/58292da6da3e5eb4f60689ebc5f7fab1796a9e60
Comment 4 Michael Felczak 2011-08-16 10:35:01 PDT
Review absolute due date always set to today
https://github.com/pkp/ocs/commit/1e632003af7ca6c1eebd2b288aa123d4a8ec6c45
Comment 5 Michael Felczak 2011-08-16 10:35:56 PDT
Fixed.