|
PKP Bugzilla – Full Text Bug Listing |
| Summary: | Misnamed variable in templates/article/article.tpl | ||
|---|---|---|---|
| Product: | OJS | Reporter: | Matthew Crider <mattcrider> |
| Component: | Reading Tools | Assignee: | Matthew Crider <mattcrider> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alec, tdthom, vlilloh |
| Priority: | P5 | ||
| Version: | 2.3.3 | ||
| Hardware: | PC | ||
| OS: | Mac OS X 10.6 | ||
| Version Reported In: | Also Affects: | ||
| Attachments: |
Patch against OJS 2.3.3-2
Patch against OJS 2.3.3-2 Patch against OJS 2.3.3-2 Patch against PKP-lib HEAD Combined Patch against OJS pre-2.3.3-2 Combined Patch against OJS pre-2.3.3-2 |
||
|
Description
Matthew Crider
2010-10-18 17:04:22 PDT
Created attachment 3292 [details] Patch against OJS 2.3.3-2 (Uploaded patch is equivalent to Matt's link in comment #1.) The PDF fails to load for me in Firefox now with this change (on Windows 7). Reverting it back to $noPluginKey works. But neither work in IE8. Created attachment 3300 [details]
Patch against OJS 2.3.3-2
The noPluginText variable wasn't properly escaped--This should be what was causing the display issue. tdthom, are you sure you have the acrobat plugin installed for internet explorer?
Thanks, that works. I am not sure what is going on with internet explorer - it does load pdfs from other sites in the browser window. If it helps IE8 reports this error when the page loads: ... Message: Invalid argument. Line: 116 Char: 165 Code: 0 URI: http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js Matt, you should use {...|escape:"javascript"} when escaping values that are dumped into Javascript variables; also, the same bug exists elsewhere on the page. Use the W3C validator.
Created attachment 3301 [details] Patch against OJS 2.3.3-2 Properly escapes all variables in PDF viewer script; Fixes some other W3C validation issues. http://github.com/pkp/ojs/commit/149adc3cc80c472b1b30fb35da6fdfe3381f5412 Created attachment 3302 [details] Patch against PKP-lib HEAD Some additional Validation warning fixes for the Google CDN script call. http://github.com/pkp/pkp-lib/commit/2dd0eef871f496a80d3947fe3f7343ee58f4d5d2 tdthom, I'm able to see the embedded PDFs fine in IE8, but you could very well have run into an issue fixed by these patches. Could you apply the latest OJS patch and try again? For consistency -- and for JS-incapable browsers -- it's best to use "// -->" for the end HTML quote rather than just "-->" (see templates/article/footer.tpl and elsewhere for examples). Could you put together a single patch against OJS 2.3.3-2 that combines these? Created attachment 3303 [details] Combined Patch against OJS pre-2.3.3-2 Combined patch of the above three patches and http://github.com/pkp/ojs/commit/b2d58392aafc6b53979d18478bb74153dc07485c There's still some inconsistency in the escaping of the {$pdfUrl} variable in JS in the last patch.
Created attachment 3304 [details]
Combined Patch against OJS pre-2.3.3-2
Aargh, sorry Alec.
tdthom, if you get the chance, can you try Matt's most recent patch to see if it corrects the problem? Hi, sorry for the delay. I have installed the patches and they work fine in Firefox and IE8 in 32bit mode (but not 64bit, presumably because acrobat reader is 32bit). So yes, thanks for the patches. Thanks, tdthom, much appreciated. Matt, I think everything has been committed? If so, feel free to close. I've moved this onto the recommended patch list for OJS 2.3.3-2. Yes. Glad to put this one to rest :) Committed to OJS 2.3.3-3 |