|
PKP Bugzilla – Full Text Bug Listing |
| Summary: | Add DOI information to export plugins | ||
|---|---|---|---|
| Product: | OJS | Reporter: | James MacGregor <jmacgreg> |
| Component: | Plug-ins | Assignee: | PKP Support <pkp-support> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | a.marchitelli, alec, juan, p.farleigh |
| Priority: | P5 | ||
| Version: | 2.3.4 | ||
| Hardware: | PC | ||
| OS: | Mac OS X 10.3 | ||
| Version Reported In: | 2.3.0 | Also Affects: | |
| Bug Depends on: | 5500 | ||
| Bug Blocks: | |||
| Attachments: | Patch against OJS 2.3.3-3 | ||
|
Description
James MacGregor
2009-12-17 15:36:20 PST
I'll open discussion here on whether we should store DOI's as article metadata. Recently, someone asked what happens if you change the DOI prefix in the Setup. Currently, the DOI would be exposed based on whatever is auto-generated on demand. However, there's an argument to be made that DOI's should be generated ONCE and if the pattern changes, then all the previously exposed DOIs are invalid. (In reply to comment #1) > I'll open discussion here on whether we should store DOI's as article metadata. > Recently, someone asked what happens if you change the DOI prefix in the > Setup. Currently, the DOI would be exposed based on whatever is auto-generated > on demand. However, there's an argument to be made that DOI's should be > generated ONCE and if the pattern changes, then all the previously exposed DOIs > are invalid. Juan, it makes sense to me that an identifier that should be considered permanent should be created once and associated with that particular record. I don't really see a situation where a journal would change its DOI-generation method, but you never know; if they do, we should ensure that all those previously-generated DOIs should still work as expected (that is, presumably, that they are generated once and stored/associated permanently with the rest of the article metadata). FYI, U of C's PID plugin will set a good pattern for this. It's simply a matter of generating and storing the DOI when the published_articles entry is created (or perhaps when the articles entry is). New action available for upgrades: <code function="installEmailTemplate" key="SUBSCRIPTION_RENEW_INSTL" locales="en_US,fr_CA" /> Oops! Wrong entry. Hi, I think that is very important to expose DOI via OAI-PMH! Any news about this improvement? Andrea Added to COinS plugin http://github.com/pkp/ojs/commit/033c3b5171baee6a9f743867f6823311a01e68a3 *** Bug 4565 has been marked as a duplicate of this bug. *** Remaining to be done: - Webfeed plugins (Bug 4565); - all citation format plugins, if relevant; - METS and Resolver Gateway plugins(?); - all oaiMetadataFormats plugins - METS export plugin - Consider for native import, but this would depend on a change to storage as discussed in comments Added DOI to DC OAI. Maybe could be useful also add DOI to TOC? See http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=4194 Yes, Andrea -- see also bug #5524. - Changed DOI storage to persist DOIs, once generated - Added DOI import to native import/export plugin - Added DOI lookups to resolver plugin http://github.com/pkp/ojs/commit/83e83b81b8463d66be1a6f165d562685ccf91922 Deferring for consideration elsewhere: - OAI metadata plugins other than NLM and DC (which already support DOI) - Citation plugins (which will be better served by refactoring first) Created attachment 3412 [details]
Patch against OJS 2.3.3-3
Fixed DOI import.
Gives the error: "patch unexpectedly ends in middle of line"
And looking at the code it does seem to end in mid-air. The last line being:
if ($publishedDate === -1) {
Snowy, that patch is correct; how are you applying it? Removed asc/desc cruft https://github.com/pkp/ojs/commit/939f975f6a44b04bf3d3e5896b58f95eeb906952 Removed asc/desc cruft https://github.com/pkp/ojs/commit/ae058a16255afbc9444ec7217de7e2b7ea47d519 |