7714 2012-07-23 22:26:00 -0700 Unable to review in track director 2012-08-09 09:36:17 -0700 1 1 1 Unclassified OCS Review 2.3.6 All All RESOLVED FIXED P3 minor --- 1 was.uthm pkp-support alec 29823 was.uthm 2012-07-23 22:26:46 -0700 I think this is not correct. When the track director click unable to review, the result will be review Underway. See here: http://pkp.sfu.ca/support/forum/viewtopic.php?f=3&t=8860 Regards, Waluyo 29832 3827 alec 2012-07-24 16:04:59 -0700 Created attachment 3827 Patch against OCS pre-2.4.0 Waluyo, could you try the attached patch? 29833 alec 2012-07-24 16:10:02 -0700 Fix decline by proxy https://github.com/pkp/ocs/commit/eddd0691f80aebf295983e9618e1d821de0cc77d 30195 alec 2012-08-09 09:36:17 -0700 Note that the attached patch will need a slight tweak for application to OCS 2.3.x. See the linked thread: http://pkp.sfu.ca/support/forum/viewtopic.php?f=3&t=8860#p34671 3827 2012-07-24 16:04:00 -0700 2012-07-24 16:04:59 -0700 Patch against OCS pre-2.4.0 7714.diff text/plain 4366 alec ZGlmZiAtLWdpdCBhL2NsYXNzZXMvc3VibWlzc2lvbi90cmFja0RpcmVjdG9yL1RyYWNrRGlyZWN0 b3JBY3Rpb24uaW5jLnBocCBiL2NsYXNzZXMvc3VibWlzc2lvbi90cmFja0RpcmVjdG9yL1RyYWNr RGlyZWN0b3JBY3Rpb24uaW5jLnBocAppbmRleCBhMTQ4OTc2Li43NDRhODE3IDEwMDY0NAotLS0g YS9jbGFzc2VzL3N1Ym1pc3Npb24vdHJhY2tEaXJlY3Rvci9UcmFja0RpcmVjdG9yQWN0aW9uLmlu Yy5waHAKKysrIGIvY2xhc3Nlcy9zdWJtaXNzaW9uL3RyYWNrRGlyZWN0b3IvVHJhY2tEaXJlY3Rv ckFjdGlvbi5pbmMucGhwCkBAIC0xNjU5LDggKzE2NTksOSBAQCBpbXBvcnQoJ2NsYXNzZXMuZmls ZS5QYXBlckZpbGVNYW5hZ2VyJyk7CiAJLyoqCiAJICogQWNjZXB0cyB0aGUgcmV2aWV3IGFzc2ln bm1lbnQgb24gYmVoYWxmIG9mIGl0cyByZXZpZXdlci4KIAkgKiBAcGFyYW0gJHJldmlld0lkIGlu dAorCSAqIEBwYXJhbSAkYWNjZXB0IGJvb2xlYW4KIAkgKi8KLQlmdW5jdGlvbiBjb25maXJtUmV2 aWV3Rm9yUmV2aWV3ZXIoJHJldmlld0lkKSB7CisJZnVuY3Rpb24gY29uZmlybVJldmlld0ZvclJl dmlld2VyKCRyZXZpZXdJZCwgJGFjY2VwdCkgewogCQkkcmV2aWV3QXNzaWdubWVudERhbyA9JiBE QU9SZWdpc3RyeTo6Z2V0REFPKCdSZXZpZXdBc3NpZ25tZW50REFPJyk7CiAJCSR1c2VyRGFvID0m IERBT1JlZ2lzdHJ5OjpnZXREQU8oJ1VzZXJEQU8nKTsKIAkJJHVzZXIgPSYgUmVxdWVzdDo6Z2V0 VXNlcigpOwpAQCAtMTY2OCwxMiArMTY2OSwxMiBAQCBpbXBvcnQoJ2NsYXNzZXMuZmlsZS5QYXBl ckZpbGVNYW5hZ2VyJyk7CiAJCSRyZXZpZXdBc3NpZ25tZW50ID0mICRyZXZpZXdBc3NpZ25tZW50 RGFvLT5nZXRCeUlkKCRyZXZpZXdJZCk7CiAJCSRyZXZpZXdlciA9JiAkdXNlckRhby0+Z2V0VXNl cigkcmV2aWV3QXNzaWdubWVudC0+Z2V0UmV2aWV3ZXJJZCgpLCB0cnVlKTsKIAotCQlpZiAoSG9v a1JlZ2lzdHJ5OjpjYWxsKCdUcmFja0RpcmVjdG9yQWN0aW9uOjpjb25maXJtUmV2aWV3Rm9yUmV2 aWV3ZXInLCBhcnJheSgmJHJldmlld0Fzc2lnbm1lbnQsICYkcmV2aWV3ZXIpKSkgcmV0dXJuOwor CQlpZiAoSG9va1JlZ2lzdHJ5OjpjYWxsKCdUcmFja0RpcmVjdG9yQWN0aW9uOjpjb25maXJtUmV2 aWV3Rm9yUmV2aWV3ZXInLCBhcnJheSgmJHJldmlld0Fzc2lnbm1lbnQsICYkcmV2aWV3ZXIsICYk YWNjZXB0KSkpIHJldHVybjsKIAogCQkvLyBPbmx5IGNvbmZpcm0gdGhlIHJldmlldyBmb3IgdGhl IHJldmlld2VyIGlmCiAJCS8vIGhlIGhhcyBub3QgcHJldmlvdXNseSBkb25lIHNvLgogCQlpZiAo JHJldmlld0Fzc2lnbm1lbnQtPmdldERhdGVDb25maXJtZWQoKSA9PSBudWxsKSB7Ci0JCQkkcmV2 aWV3QXNzaWdubWVudC0+c2V0RGVjbGluZWQoMCk7CisJCQkkcmV2aWV3QXNzaWdubWVudC0+c2V0 RGVjbGluZWQoJGFjY2VwdD8wOjEpOwogCQkJJHJldmlld0Fzc2lnbm1lbnQtPnNldERhdGVDb25m aXJtZWQoQ29yZTo6Z2V0Q3VycmVudERhdGUoKSk7CiAJCQkkcmV2aWV3QXNzaWdubWVudC0+c3Rh bXBNb2RpZmllZCgpOwogCQkJJHJldmlld0Fzc2lnbm1lbnREYW8tPnVwZGF0ZVJldmlld0Fzc2ln bm1lbnQoJHJldmlld0Fzc2lnbm1lbnQpOwpAQCAtMTY4Nyw3ICsxNjg4LDcgQEAgaW1wb3J0KCdj bGFzc2VzLmZpbGUuUGFwZXJGaWxlTWFuYWdlcicpOwogCQkJJGVudHJ5LT5zZXRVc2VySWQoJHVz ZXItPmdldElkKCkpOwogCQkJJGVudHJ5LT5zZXREYXRlTG9nZ2VkKENvcmU6OmdldEN1cnJlbnRE YXRlKCkpOwogCQkJJGVudHJ5LT5zZXRFdmVudFR5cGUoUEFQRVJfTE9HX1JFVklFV19BQ0NFUFRf QllfUFJPWFkpOwotCQkJJGVudHJ5LT5zZXRMb2dNZXNzYWdlKCdsb2cucmV2aWV3LnJldmlld0Fj Y2VwdGVkQnlQcm94eScsIGFycmF5KCdyZXZpZXdlck5hbWUnID0+ICRyZXZpZXdlci0+Z2V0RnVs bE5hbWUoKSwgJ3BhcGVySWQnID0+ICRyZXZpZXdBc3NpZ25tZW50LT5nZXRTdWJtaXNzaW9uSWQo KSwgJ3N0YWdlJyA9PiAkcmV2aWV3QXNzaWdubWVudC0+Z2V0Um91bmQoKSwgJ3VzZXJOYW1lJyA9 PiAkdXNlci0+Z2V0RnVsbE5hbWUoKSkpOworCQkJJGVudHJ5LT5zZXRMb2dNZXNzYWdlKCRhY2Nl cHQ/J2xvZy5yZXZpZXcucmV2aWV3QWNjZXB0ZWRCeVByb3h5JzonbG9nLnJldmlldy5yZXZpZXdE ZWNsaW5lZEJ5UHJveHknLCBhcnJheSgncmV2aWV3ZXJOYW1lJyA9PiAkcmV2aWV3ZXItPmdldEZ1 bGxOYW1lKCksICdwYXBlcklkJyA9PiAkcmV2aWV3QXNzaWdubWVudC0+Z2V0U3VibWlzc2lvbklk KCksICdzdGFnZScgPT4gJHJldmlld0Fzc2lnbm1lbnQtPmdldFJvdW5kKCksICd1c2VyTmFtZScg PT4gJHVzZXItPmdldEZ1bGxOYW1lKCkpKTsKIAkJCSRlbnRyeS0+c2V0QXNzb2NUeXBlKExPR19U WVBFX1JFVklFVyk7CiAJCQkkZW50cnktPnNldEFzc29jSWQoJHJldmlld0Fzc2lnbm1lbnQtPmdl dElkKCkpOwogCmRpZmYgLS1naXQgYS9sb2NhbGUvZW5fVVMvbG9jYWxlLnhtbCBiL2xvY2FsZS9l bl9VUy9sb2NhbGUueG1sCmluZGV4IDIwZTFiZjkuLmQwMmNjNzggMTAwNjQ0Ci0tLSBhL2xvY2Fs ZS9lbl9VUy9sb2NhbGUueG1sCisrKyBiL2xvY2FsZS9lbl9VUy9sb2NhbGUueG1sCkBAIC03ODEs NiArNzgxLDcgQEAgWW91ciBzZXJ2ZXIgY3VycmVudGx5IHN1cHBvcnRzIG1ic3RyaW5nOiA8c3Ry b25nPnskc3VwcG9ydHNNQlN0cmluZ308L3N0cm9uZz5dXT4KIAk8bWVzc2FnZSBrZXk9ImxvZy5y ZXZpZXcucmV2aWV3RGVjbGluZWQiPnskcmV2aWV3ZXJOYW1lfSBoYXMgZGVjbGluZWQgdGhlIHN0 YWdlIHskc3RhZ2V9IHJldmlldyBmb3Igc3VibWlzc2lvbiB7JHBhcGVySWR9LjwvbWVzc2FnZT4K IAk8bWVzc2FnZSBrZXk9ImxvZy5yZXZpZXcucmV2aWV3QWNjZXB0ZWQiPnskcmV2aWV3ZXJOYW1l fSBoYXMgYWNjZXB0ZWQgdGhlIHN0YWdlIHskc3RhZ2V9IHJldmlldyBmb3Igc3VibWlzc2lvbiB7 JHBhcGVySWR9LjwvbWVzc2FnZT4KIAk8bWVzc2FnZSBrZXk9ImxvZy5yZXZpZXcucmV2aWV3QWNj ZXB0ZWRCeVByb3h5Ij57JHVzZXJOYW1lfSBoYXMgYWNjZXB0ZWQgdGhlIHN0YWdlIHskc3RhZ2V9 IHJldmlldyBmb3Igc3VibWlzc2lvbiB7JHBhcGVySWR9IG9uIGJlaGFsZiBvZiB7JHJldmlld2Vy TmFtZX0uPC9tZXNzYWdlPgorCTxtZXNzYWdlIGtleT0ibG9nLnJldmlldy5yZXZpZXdEZWNsaW5l ZEJ5UHJveHkiPnskdXNlck5hbWV9IGhhcyBkZWNsaW5lZCB0aGUgc3RhZ2UgeyRzdGFnZX0gcmV2 aWV3IGZvciBzdWJtaXNzaW9uIHskcGFwZXJJZH0gb24gYmVoYWxmIG9mIHskcmV2aWV3ZXJOYW1l fS48L21lc3NhZ2U+CiAJPG1lc3NhZ2Uga2V5PSJsb2cucmV2aWV3LnJldmlld0ZpbGVCeVByb3h5 Ij5UaGUgRGlyZWN0b3IsIHskdXNlck5hbWV9LCBoYXMgdXBsb2FkZWQgYSByZXZpZXcgZmlsZSBm b3Igc3RhZ2UgeyRzdGFnZX0gb2Ygc3VibWlzc2lvbiB7JHBhcGVySWR9IG9uIGJlaGFsZiBvZiB0 aGUgcmV2aWV3ZXIsIHskcmV2aWV3ZXJOYW1lfS48L21lc3NhZ2U+CiAJPG1lc3NhZ2Uga2V5PSJs b2cucmV2aWV3LnJldmlld2VyRmlsZSI+QSByZXZpZXdlciBmaWxlIGhhcyBiZWVuIHVwbG9hZGVk LjwvbWVzc2FnZT4KIAk8bWVzc2FnZSBrZXk9ImxvZy5kaXJlY3Rvci5kZWNpc2lvbiI+QSBkaXJl Y3RvciBkZWNpc2lvbiAoeyRkZWNpc2lvbn0pIGZvciBwYXBlciB7JHBhcGVySWR9IHdhcyByZWNv cmRlZCBieSB7JGRpcmVjdG9yTmFtZX0uPC9tZXNzYWdlPgpkaWZmIC0tZ2l0IGEvcGFnZXMvdHJh Y2tEaXJlY3Rvci9TdWJtaXNzaW9uRWRpdEhhbmRsZXIuaW5jLnBocCBiL3BhZ2VzL3RyYWNrRGly ZWN0b3IvU3VibWlzc2lvbkVkaXRIYW5kbGVyLmluYy5waHAKaW5kZXggY2I2MmZjZi4uNTk5YjY5 OSAxMDA2NDQKLS0tIGEvcGFnZXMvdHJhY2tEaXJlY3Rvci9TdWJtaXNzaW9uRWRpdEhhbmRsZXIu aW5jLnBocAorKysgYi9wYWdlcy90cmFja0RpcmVjdG9yL1N1Ym1pc3Npb25FZGl0SGFuZGxlci5p bmMucGhwCkBAIC03NTIsNyArNzUyLDcgQEAgY2xhc3MgU3VibWlzc2lvbkVkaXRIYW5kbGVyIGV4 dGVuZHMgVHJhY2tEaXJlY3RvckhhbmRsZXIgewogCQkkc2NoZWRDb25mID0mICRyZXF1ZXN0LT5n ZXRTY2hlZENvbmYoKTsKIAkJJHN1Ym1pc3Npb24gPSYgJHRoaXMtPnN1Ym1pc3Npb247CiAKLQkJ VHJhY2tEaXJlY3RvckFjdGlvbjo6Y29uZmlybVJldmlld0ZvclJldmlld2VyKCRyZXZpZXdJZCk7 CisJCVRyYWNrRGlyZWN0b3JBY3Rpb246OmNvbmZpcm1SZXZpZXdGb3JSZXZpZXdlcigkcmV2aWV3 SWQsICRhY2NlcHQpOwogCQkkcmVxdWVzdC0+cmVkaXJlY3QobnVsbCwgbnVsbCwgbnVsbCwgJ3N1 Ym1pc3Npb25SZXZpZXcnLCAkcGFwZXJJZCk7CiAJfQogCg==