6888 2011-09-16 12:13:00 -0700 Review Due Date can only be set up to 2011 2011-09-19 12:06:20 -0700 1 1 1 Unclassified OCS Review 2.3.4 All All RESOLVED FIXED P3 normal --- 1 jmacgreg pkp-support michael.pkp 25412 jmacgreg 2011-09-16 12:13:40 -0700 (Courtesy of http://pkp.sfu.ca/support/forum/viewtopic.php?f=3&t=7887&p=30635#p30635) In Conference Management -> Scheduled Conference Setup -> Step 3.2, the Conference Manager can choose 2011 as the latest default due date for a review to be completed. CMs should be able to select at least a year in advance, especially for Fall submissions. The relevant snippet from the tpl file (templates/manager/schedConfSetup/step3.tpl) is as follows: {html_select_date prefix="numWeeksPerReviewAbsolute" time=$absoluteReviewDate all_extra="class=\"selectMenu\"" start_year=$firstYear end_year=$lastYear} ... and $lastYear is assigned as follows in various places (/classes/manager/form/scheduler/ScheduleForm.inc.php:132, /classes/manager/form/scheduler/SpecialEventForm.inc.php:66, /classes/manager/form/TimelineForm.inc.php:143): $templateMgr->assign('lastYear', strftime('%Y', $latestDate)) What's the best way to increment this? Should the assignment be changed, or should a new, schedConfSetup->Step3 assignment be made? (NB.: I think this is significant enough to get in for 2.3.4, especially if we release in the Fall. :D) 25433 3642 michael.pkp 2011-09-19 11:16:46 -0700 Created attachment 3642 Patch against OCS 2.3.3-1 25434 michael.pkp 2011-09-19 11:20:02 -0700 Review Due Date can only be set up to 2011 https://github.com/pkp/ocs/commit/7195615e079bb9f58c201dbc4bed35f3a1f282c1 25435 michael.pkp 2011-09-19 11:20:42 -0700 Thanks, James. In sched conf setup 3.2, neither start year nor end year were actually being set for the template -- by default the end year is the current year. The end year on the other pages looks to be correctly set into the future. 25436 michael.pkp 2011-09-19 11:25:01 -0700 Review Due Date can only be set up to 2011 https://github.com/pkp/ocs/commit/b75dab853c8590983a29af9889dc0bd28c8f5080 25437 michael.pkp 2011-09-19 11:26:03 -0700 Fixed. 25438 3643 michael.pkp 2011-09-19 11:49:17 -0700 Created attachment 3643 Patch against OCS 2.3.3-1 25439 michael.pkp 2011-09-19 11:50:02 -0700 Review Due Date can only be set up to 2011 https://github.com/pkp/ocs/commit/fcaaac39b6a0c985f63d0be4ffded682562dc67d 25440 michael.pkp 2011-09-19 11:50:02 -0700 Review Due Date can only be set up to 2011 https://github.com/pkp/ocs/commit/5b98cbf9cc59c748371d10a71c2ff5a3ec4219c4 25441 michael.pkp 2011-09-19 11:57:25 -0700 Improved fix uses year offset window based on sched conf timeline. This is more consistent with setting of start and end years in other parts of the system. 25442 michael.pkp 2011-09-19 12:05:02 -0700 Review Due Date can only be set up to 2011 https://github.com/pkp/ocs/commit/3481edfbe5bb5d4102c3f90ad91a0198f5c07907 25443 michael.pkp 2011-09-19 12:05:02 -0700 Review Due Date can only be set up to 2011 https://github.com/pkp/ocs/commit/5d448f97a00e8eddaace6e4d3b1d402eb92cbe63 3642 2011-09-19 11:16:00 -0700 2011-09-19 11:49:17 -0700 Patch against OCS 2.3.3-1 6888.diff text/plain 1960 michael.pkp LS0tIGEvY2xhc3Nlcy9tYW5hZ2VyL2Zvcm0vc2NoZWRDb25mU2V0dXAvU2NoZWRDb25mU2V0dXBT dGVwM0Zvcm0uaW5jLnBocAorKysgYi9jbGFzc2VzL21hbmFnZXIvZm9ybS9zY2hlZENvbmZTZXR1 cC9TY2hlZENvbmZTZXR1cFN0ZXAzRm9ybS5pbmMucGhwCkBAIC0xMiw3ICsxMiw4IEBACiAgKiBA YnJpZWYgRm9ybSBmb3IgU3RlcCAzIG9mIHNjaGVkdWxlZCBjb25mZXJlbmNlIHNldHVwLgogICov CiAKLS8vJElkJAorZGVmaW5lKCdSRVZJRVdfWUVBUl9PRkZTRVRfUEFTVCcsCQknLTEwJyk7Citk ZWZpbmUoJ1JFVklFV19ZRUFSX09GRlNFVF9GVVRVUkUnLAkJJysxMCcpOwogCiBpbXBvcnQoIm1h bmFnZXIuZm9ybS5zY2hlZENvbmZTZXR1cC5TY2hlZENvbmZTZXR1cEZvcm0iKTsKIApAQCAtNzgs NiArNzksOSBAQCBjbGFzcyBTY2hlZENvbmZTZXR1cFN0ZXAzRm9ybSBleHRlbmRzIFNjaGVkQ29u ZlNldHVwRm9ybSB7CiAJCWlmIChDb25maWc6OmdldFZhcignZ2VuZXJhbCcsICdzY2hlZHVsZWRf dGFza3MnKSkKIAkJCSR0ZW1wbGF0ZU1nci0+YXNzaWduKCdzY2hlZHVsZWRUYXNrc0VuYWJsZWQn LCB0cnVlKTsKIAorCQkkdGVtcGxhdGVNZ3ItPmFzc2lnbigncmV2aWV3WWVhck9mZnNldFBhc3Qn LCBSRVZJRVdfWUVBUl9PRkZTRVRfUEFTVCk7CisJCSR0ZW1wbGF0ZU1nci0+YXNzaWduKCdyZXZp ZXdZZWFyT2Zmc2V0RnV0dXJlJywgUkVWSUVXX1lFQVJfT0ZGU0VUX0ZVVFVSRSk7CisKIAkJcGFy ZW50OjpkaXNwbGF5KCk7CiAJfQogCQotLS0gYS90ZW1wbGF0ZXMvbWFuYWdlci9zY2hlZENvbmZT ZXR1cC9zdGVwMy50cGwKKysrIGIvdGVtcGxhdGVzL21hbmFnZXIvc2NoZWRDb25mU2V0dXAvc3Rl cDMudHBsCkBAIC02NSw3ICs2NSw3IEBACiAJCXt0cmFuc2xhdGUga2V5PSJtYW5hZ2VyLnNjaGVk Q29uZlNldHVwLnJldmlldy5udW1XZWVrc1BlclJldmlldzIifTxici8+CiAJPGlucHV0IHR5cGU9 InJhZGlvIiBuYW1lPSJyZXZpZXdEZWFkbGluZVR5cGUiIGlkPSJyZXZpZXdEZWFkbGluZS0yIiB2 YWx1ZT0ieyRzbWFydHkuY29uc3QuUkVWSUVXX0RFQURMSU5FX1RZUEVfQUJTT0xVVEV9IiB7aWYg JHJldmlld0RlYWRsaW5lVHlwZSA9PSAkc21hcnR5LmNvbnN0LlJFVklFV19ERUFETElORV9UWVBF X0FCU09MVVRFfSBjaGVja2VkPSJjaGVja2VkInsvaWZ9IC8+CiAJCXt0cmFuc2xhdGUga2V5PSJt YW5hZ2VyLnNjaGVkQ29uZlNldHVwLnJldmlldy5udW1XZWVrc1BlclJldmlldzFiIn0mbmJzcDsK LQkJe2h0bWxfc2VsZWN0X2RhdGUgcHJlZml4PSJudW1XZWVrc1BlclJldmlld0Fic29sdXRlIiB0 aW1lPSRhYnNvbHV0ZVJldmlld0RhdGUgYWxsX2V4dHJhPSJjbGFzcz1cInNlbGVjdE1lbnVcIiIg c3RhcnRfeWVhcj0kZmlyc3RZZWFyIGVuZF95ZWFyPSRsYXN0WWVhcn0KKwkJe2h0bWxfc2VsZWN0 X2RhdGUgcHJlZml4PSJudW1XZWVrc1BlclJldmlld0Fic29sdXRlIiB0aW1lPSRhYnNvbHV0ZVJl dmlld0RhdGUgYWxsX2V4dHJhPSJjbGFzcz1cInNlbGVjdE1lbnVcIiIgc3RhcnRfeWVhcj0kcmV2 aWV3WWVhck9mZnNldFBhc3QgZW5kX3llYXI9JHJldmlld1llYXJPZmZzZXRGdXR1cmV9CiAJCXt0 cmFuc2xhdGUga2V5PSJtYW5hZ2VyLnNjaGVkQ29uZlNldHVwLnJldmlldy5udW1XZWVrc1BlclJl dmlldzJiIn08YnIvPgogCTxpbnB1dCB0eXBlPSJjaGVja2JveCIgbmFtZT0icmVzdHJpY3RSZXZp ZXdlckZpbGVBY2Nlc3MiIGlkPSJyZXN0cmljdFJldmlld2VyRmlsZUFjY2VzcyIgdmFsdWU9IjEi e2lmICRyZXN0cmljdFJldmlld2VyRmlsZUFjY2Vzc30gY2hlY2tlZD0iY2hlY2tlZCJ7L2lmfSAv PiZuYnNwOzxsYWJlbCBmb3I9InJlc3RyaWN0UmV2aWV3ZXJGaWxlQWNjZXNzIj57dHJhbnNsYXRl IGtleT0ibWFuYWdlci5zY2hlZENvbmZTZXR1cC5yZXZpZXcucmVzdHJpY3RSZXZpZXdlckZpbGVB Y2Nlc3MifTwvbGFiZWw+CiA8L3A+Cg== 3643 2011-09-19 11:49:00 -0700 2011-09-19 11:49:17 -0700 Patch against OCS 2.3.3-1 6888_2.diff text/plain 667 michael.pkp LS0tIGEvY2xhc3Nlcy9tYW5hZ2VyL2Zvcm0vc2NoZWRDb25mU2V0dXAvU2NoZWRDb25mU2V0dXBT dGVwM0Zvcm0uaW5jLnBocAorKysgYi9jbGFzc2VzL21hbmFnZXIvZm9ybS9zY2hlZENvbmZTZXR1 cC9TY2hlZENvbmZTZXR1cFN0ZXAzRm9ybS5pbmMucGhwCkBAIC03Niw2ICs3NiwxMiBAQCBjbGFz cyBTY2hlZENvbmZTZXR1cFN0ZXAzRm9ybSBleHRlbmRzIFNjaGVkQ29uZlNldHVwRm9ybSB7CiAJ CWlmIChDb25maWc6OmdldFZhcignZ2VuZXJhbCcsICdzY2hlZHVsZWRfdGFza3MnKSkKIAkJCSR0 ZW1wbGF0ZU1nci0+YXNzaWduKCdzY2hlZHVsZWRUYXNrc0VuYWJsZWQnLCB0cnVlKTsKIAorCQlp bXBvcnQoJ21hbmFnZXIuZm9ybS5UaW1lbGluZUZvcm0nKTsKKwkJJHNjaGVkQ29uZiA9JiBSZXF1 ZXN0OjpnZXRTY2hlZENvbmYoKTsKKwkJbGlzdCgkZWFybGllc3REYXRlLCAkbGF0ZXN0RGF0ZSkg PSBUaW1lbGluZUZvcm06OmdldE91dHNpZGVEYXRlcygkc2NoZWRDb25mKTsKKwkJJHRlbXBsYXRl TWdyLT5hc3NpZ24oJ2ZpcnN0WWVhcicsIHN0cmZ0aW1lKCclWScsICRlYXJsaWVzdERhdGUpKTsK KwkJJHRlbXBsYXRlTWdyLT5hc3NpZ24oJ2xhc3RZZWFyJywgc3RyZnRpbWUoJyVZJywgJGxhdGVz dERhdGUpKTsKKwogCQlwYXJlbnQ6OmRpc3BsYXkoKTsKIAl9CiAJCg==