6876 2011-09-07 11:45:00 -0700 Galleys uploaded in Firefox not indexed for search 2012-09-24 09:08:52 -0700 1 1 1 Unclassified OCS General 2.3.4 All All RESOLVED FIXED P3 normal --- 1 michael.pkp michael.pkp alec pkp-support 2.3.3 OHS 2.3.2 OJS 2.3.7 25259 michael.pkp 2011-09-07 11:45:28 -0700 Galley upload form does not report correct file type for PDFs. External indexing app never invoked and galley remains unindexed. 25260 3633 michael.pkp 2011-09-07 11:49:53 -0700 Created attachment 3633 Patch against OCS 2.3.3-1 25261 michael.pkp 2011-09-07 11:50:02 -0700 PDF galleys not indexed for search https://github.com/pkp/ocs/commit/1bae4b11b82ec2983fba3ee4dd6610da773f9232 25265 michael.pkp 2011-09-07 12:50:02 -0700 PDF galleys not indexed for search https://github.com/pkp/ocs/commit/ee865293da3790e14ca773e8bf30a6bb9adc62e4 25266 michael.pkp 2011-09-07 13:21:26 -0700 Looking into this a bit more it appears to be a browser issue. Firefox (OSX, 5.0) reports the file type as application/download whereas other browsers correctly identify the file as application/pdf We really shouldn't rely on the browser for this info, i.e. $_FILES['userfile']['type'] The mime type of the file, if the browser provided this information. An example would be "image/gif". This mime type is however not checked on the PHP side and therefore don't take its value for granted. This should be fixed in all apps to use mime_content_type on the server. 25282 michael.pkp 2011-09-07 22:08:39 -0700 This problem applies to other versions of Firefox on other platforms as well: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/84880 http://forums.mozillazine.org/viewtopic.php?f=9&t=2241011 25284 michael.pkp 2011-09-08 09:33:52 -0700 Good explanation of the issue: http://techblog.procurios.nl/k/n618/news/view/15872/14863/Mimetype-corruption-in-Firefox.html 25297 michael.pkp 2011-09-09 12:10:52 -0700 Looking at some real world data, this issue also applies to MS Word and PowerPoint galleys. Rather than application/msword and application/vnd.ms-powerpoint these are sometimes saved as application/octet-stream and will not be indexed. Need to manually fix these to the correct mime types. .docx should be saved as application/vnd.openxmlformats-officedocument.wordprocessingml.document This apparently supersedes application/msword 25298 michael.pkp 2011-09-09 12:19:09 -0700 Need to manually fix: * doc: application/msword * ppt: application/vnd.ms-powerpoint * pps: application/vnd.ms-powerpoint * docx: application/vnd.openxmlformats-officedocument.wordprocessingml.document * pptx: application/vnd.openxmlformats-officedocument.presentationml.presentation * ppsx: application/vnd.openxmlformats-officedocument.presentationml.slideshow 25304 michael.pkp 2011-09-09 15:45:02 -0700 Galleys uploaded in Firefox not indexed for search https://github.com/pkp/ocs/commit/74879827587d508675503d3079db739f1c24d203 25305 michael.pkp 2011-09-09 15:45:02 -0700 Galleys uploaded in Firefox not indexed for search https://github.com/pkp/pkp-lib/commit/a8fbae1cabc6251069bc1e5792e9bf465aee09a6 25306 michael.pkp 2011-09-09 15:48:22 -0700 Port to OCS master. Check and port as needed to OJS, OMP, and OHS. 25476 michael.pkp 2011-09-28 21:55:02 -0700 PDF galleys not indexed for search https://github.com/pkp/ocs/commit/baf880c2057c1aac43f66f19fc4f610009c5b316 25477 michael.pkp 2011-09-29 21:00:02 -0700 Galleys uploaded in Firefox not indexed for search https://github.com/pkp/ojs/commit/7178b64b1aec39dcc94918ecd379ee9fe7f9c3de 25478 michael.pkp 2011-09-29 21:55:02 -0700 Galleys uploaded in Firefox not indexed for search https://github.com/pkp/ojs/commit/e24789a97ffb52f9a8d0939b7a455689dd7afa0f 25479 michael.pkp 2011-09-29 22:15:01 -0700 Don't rely on Firefox mimetype for uploaded files https://github.com/pkp/pkp-lib/commit/753aaf9ddc961cd78b92c6b5cd2768778cf582a5 25480 michael.pkp 2011-09-29 22:46:09 -0700 Ported to OCS master, OJS, and OHS. OMP not affected. 25576 3657 michael.pkp 2011-10-11 22:11:40 -0700 Created attachment 3657 Patch against OJS 2.3.6 Patch should also apply cleanly to older versions of OJS 2.3.x 25577 3658 michael.pkp 2011-10-11 22:21:02 -0700 Created attachment 3658 OCS MySQL database update 25578 3659 michael.pkp 2011-10-11 22:22:35 -0700 Created attachment 3659 OCS PostgreSQL database update 25579 3660 michael.pkp 2011-10-11 22:23:12 -0700 Created attachment 3660 OJS MySQL database update 25580 3661 michael.pkp 2011-10-11 22:23:42 -0700 Created attachment 3661 OJS PostgreSQL database update 25581 michael.pkp 2011-10-11 22:29:27 -0700 The fix, database update, and search index rebuild will automatically be executed as part of the OCS 2.3.4 upgrade. To manually fix on OCS 2.3.3-1 or older: 1) Apply the patch to your OCS install 2) Manually execute the database update statements 3) Rebuild your paper search index, i.e. php tools/rebuildSearchIndex.php 25582 michael.pkp 2011-10-11 22:30:23 -0700 The fix, database update, and search index rebuild will automatically be executed as part of the OJS 2.3.7 upgrade. To manually fix on OCS 2.3.6 or older: 1) Apply the patch to your OCS install 2) Manually execute the database update statements 3) Rebuild your article search index, i.e. php tools/rebuildSearchIndex.php 25583 michael.pkp 2011-10-11 22:32:06 -0700 (In reply to comment #23) > To manually fix on OCS 2.3.6 or older: This should read "OJS 2.3.6 or older" 31528 alec 2012-09-24 09:08:52 -0700 This was already fixed. 3633 2011-09-07 11:49:00 -0700 2011-09-07 11:49:53 -0700 Patch against OCS 2.3.3-1 6876.diff text/plain 536 michael.pkp LS0tIGEvY2xhc3Nlcy9maWxlL1BhcGVyRmlsZU1hbmFnZXIuaW5jLnBocAorKysgYi9jbGFzc2Vz L2ZpbGUvUGFwZXJGaWxlTWFuYWdlci5pbmMucGhwCkBAIC00OTEsNyArNDkxLDcgQEAgY2xhc3Mg UGFwZXJGaWxlTWFuYWdlciBleHRlbmRzIEZpbGVNYW5hZ2VyIHsKIAkJCSRwYXBlckZpbGUtPnNl dERhdGVNb2RpZmllZChDb3JlOjpnZXRDdXJyZW50RGF0ZSgpKTsKIAkJfQogCi0JCSRwYXBlckZp bGUtPnNldEZpbGVUeXBlKCRfRklMRVNbJGZpbGVOYW1lXVsndHlwZSddKTsKKwkJJHBhcGVyRmls ZS0+c2V0RmlsZVR5cGUoJHRoaXMtPmdldFVwbG9hZGVkRmlsZVR5cGUoJGZpbGVOYW1lKSk7CiAJ CSRwYXBlckZpbGUtPnNldEZpbGVTaXplKCRfRklMRVNbJGZpbGVOYW1lXVsnc2l6ZSddKTsKIAkJ JHBhcGVyRmlsZS0+c2V0T3JpZ2luYWxGaWxlTmFtZShQYXBlckZpbGVNYW5hZ2VyOjp0cnVuY2F0 ZUZpbGVOYW1lKCRfRklMRVNbJGZpbGVOYW1lXVsnbmFtZSddLCAxMjcpKTsKIAkJJHBhcGVyRmls ZS0+c2V0VHlwZSgkdHlwZVBhdGgpOwo= 3657 2011-10-11 22:11:00 -0700 2011-10-11 22:11:40 -0700 Patch against OJS 2.3.6 6876_ojs.diff text/plain 1203 michael.pkp LS0tIGEvY2xhc3Nlcy9maWxlL0FydGljbGVGaWxlTWFuYWdlci5pbmMucGhwCisrKyBiL2NsYXNz ZXMvZmlsZS9BcnRpY2xlRmlsZU1hbmFnZXIuaW5jLnBocApAQCAtNTA2LDcgKzUwNiw3IEBAIGNs YXNzIEFydGljbGVGaWxlTWFuYWdlciBleHRlbmRzIEZpbGVNYW5hZ2VyIHsKIAkJCSRhcnRpY2xl RmlsZS0+c2V0RGF0ZU1vZGlmaWVkKENvcmU6OmdldEN1cnJlbnREYXRlKCkpOwogCQl9CiAKLQkJ JGFydGljbGVGaWxlLT5zZXRGaWxlVHlwZSgkX0ZJTEVTWyRmaWxlTmFtZV1bJ3R5cGUnXSk7CisJ CSRhcnRpY2xlRmlsZS0+c2V0RmlsZVR5cGUoJHRoaXMtPmdldFVwbG9hZGVkRmlsZVR5cGUoJGZp bGVOYW1lKSk7CiAJCSRhcnRpY2xlRmlsZS0+c2V0RmlsZVNpemUoJF9GSUxFU1skZmlsZU5hbWVd WydzaXplJ10pOwogCQkkYXJ0aWNsZUZpbGUtPnNldE9yaWdpbmFsRmlsZU5hbWUoQXJ0aWNsZUZp bGVNYW5hZ2VyOjp0cnVuY2F0ZUZpbGVOYW1lKCRfRklMRVNbJGZpbGVOYW1lXVsnbmFtZSddLCAx MjcpKTsKIAkJJGFydGljbGVGaWxlLT5zZXRUeXBlKCR0eXBlUGF0aCk7Ci0tLSBhL3BhZ2VzL21h bmFnZXIvU2V0dXBIYW5kbGVyLmluYy5waHAKKysrIGIvcGFnZXMvbWFuYWdlci9TZXR1cEhhbmRs ZXIuaW5jLnBocApAQCAtMjAwLDcgKzIwMCw3IEBAIGNsYXNzIFNldHVwSGFuZGxlciBleHRlbmRz IE1hbmFnZXJIYW5kbGVyIHsKIAkJCQkJCWlmICghaXNfYXJyYXkoJHRlbXBsYXRlcykpICR0ZW1w bGF0ZXMgPSBhcnJheSgpOwogCQkJCQkJJHRlbXBsYXRlSWQgPSBjb3VudCgkdGVtcGxhdGVzKTsK IAkJCQkJCSRvcmlnaW5hbEZpbGVuYW1lID0gJF9GSUxFU1sndGVtcGxhdGUtZmlsZSddWyduYW1l J107Ci0JCQkJCQkkZmlsZVR5cGUgPSAkX0ZJTEVTWyd0ZW1wbGF0ZS1maWxlJ11bJ3R5cGUnXTsK KwkJCQkJCSRmaWxlVHlwZSA9ICRqb3VybmFsRmlsZU1hbmFnZXItPmdldFVwbG9hZGVkRmlsZVR5 cGUoJ3RlbXBsYXRlLWZpbGUnKTsKIAkJCQkJCSRmaWxlbmFtZSA9ICJ0ZW1wbGF0ZS0kdGVtcGxh dGVJZC4iIC4gJGpvdXJuYWxGaWxlTWFuYWdlci0+cGFyc2VGaWxlRXh0ZW5zaW9uKCRvcmlnaW5h bEZpbGVuYW1lKTsKIAkJCQkJCSRqb3VybmFsRmlsZU1hbmFnZXItPnVwbG9hZEZpbGUoJ3RlbXBs YXRlLWZpbGUnLCAkZmlsZW5hbWUpOwogCQkJCQkJJHRlbXBsYXRlc1skdGVtcGxhdGVJZF0gPSBh cnJheSgK 3658 2011-10-11 22:21:00 -0700 2011-10-11 22:21:53 -0700 OCS MySQL database update 6876_ocs_mysql.sql text/plain 867 michael.pkp VVBEQVRFIHBhcGVyX2ZpbGVzIFNFVCBmaWxlX3R5cGUgPSAnYXBwbGljYXRpb24vcGRmJyBXSEVS RSBvcmlnaW5hbF9maWxlX25hbWUgUkxJS0UgJ1xcLnBkZiQnOwpVUERBVEUgcGFwZXJfZmlsZXMg U0VUIGZpbGVfdHlwZSA9ICdhcHBsaWNhdGlvbi9tc3dvcmQnIFdIRVJFIG9yaWdpbmFsX2ZpbGVf bmFtZSBSTElLRSAnXFwuZG9jJCc7ClVQREFURSBwYXBlcl9maWxlcyBTRVQgZmlsZV90eXBlID0g J2FwcGxpY2F0aW9uL3ZuZC5tcy1wb3dlcnBvaW50JyBXSEVSRSBvcmlnaW5hbF9maWxlX25hbWUg UkxJS0UgJ1xcLnBwdCQnOwpVUERBVEUgcGFwZXJfZmlsZXMgU0VUIGZpbGVfdHlwZSA9ICdhcHBs aWNhdGlvbi92bmQubXMtcG93ZXJwb2ludCcgV0hFUkUgb3JpZ2luYWxfZmlsZV9uYW1lIFJMSUtF ICdcXC5wcHMkJzsKVVBEQVRFIHBhcGVyX2ZpbGVzIFNFVCBmaWxlX3R5cGUgPSAnYXBwbGljYXRp b24vdm5kLm9wZW54bWxmb3JtYXRzLW9mZmljZWRvY3VtZW50LndvcmRwcm9jZXNzaW5nbWwuZG9j dW1lbnQnIFdIRVJFIG9yaWdpbmFsX2ZpbGVfbmFtZSBSTElLRSAnXFwuZG9jeCQnOwpVUERBVEUg cGFwZXJfZmlsZXMgU0VUIGZpbGVfdHlwZSA9ICdhcHBsaWNhdGlvbi92bmQub3BlbnhtbGZvcm1h dHMtb2ZmaWNlZG9jdW1lbnQucHJlc2VudGF0aW9ubWwucHJlc2VudGF0aW9uJyBXSEVSRSBvcmln aW5hbF9maWxlX25hbWUgUkxJS0UgJ1xcLnBwdHgkJzsKVVBEQVRFIHBhcGVyX2ZpbGVzIFNFVCBm aWxlX3R5cGUgPSAnYXBwbGljYXRpb24vdm5kLm9wZW54bWxmb3JtYXRzLW9mZmljZWRvY3VtZW50 LnByZXNlbnRhdGlvbm1sLnNsaWRlc2hvdycgV0hFUkUgb3JpZ2luYWxfZmlsZV9uYW1lIFJMSUtF ICdcXC5wcHN4JCc7 3659 2011-10-11 22:22:00 -0700 2011-10-11 22:22:35 -0700 OCS PostgreSQL database update 6876_ocs_pgsql.sql text/plain 832 michael.pkp VVBEQVRFIHBhcGVyX2ZpbGVzIFNFVCBmaWxlX3R5cGUgPSAnYXBwbGljYXRpb24vcGRmJyBXSEVS RSBvcmlnaW5hbF9maWxlX25hbWUgfiogJy5wZGYkJzsKVVBEQVRFIHBhcGVyX2ZpbGVzIFNFVCBm aWxlX3R5cGUgPSAnYXBwbGljYXRpb24vbXN3b3JkJyBXSEVSRSBvcmlnaW5hbF9maWxlX25hbWUg fiogJy5kb2MkJzsKVVBEQVRFIHBhcGVyX2ZpbGVzIFNFVCBmaWxlX3R5cGUgPSAnYXBwbGljYXRp b24vdm5kLm1zLXBvd2VycG9pbnQnIFdIRVJFIG9yaWdpbmFsX2ZpbGVfbmFtZSB+KiAnLnBwdCQn OwpVUERBVEUgcGFwZXJfZmlsZXMgU0VUIGZpbGVfdHlwZSA9ICdhcHBsaWNhdGlvbi92bmQubXMt cG93ZXJwb2ludCcgV0hFUkUgb3JpZ2luYWxfZmlsZV9uYW1lIH4qICcucHBzJCc7ClVQREFURSBw YXBlcl9maWxlcyBTRVQgZmlsZV90eXBlID0gJ2FwcGxpY2F0aW9uL3ZuZC5vcGVueG1sZm9ybWF0 cy1vZmZpY2Vkb2N1bWVudC53b3JkcHJvY2Vzc2luZ21sLmRvY3VtZW50JyBXSEVSRSBvcmlnaW5h bF9maWxlX25hbWUgfiogJy5kb2N4JCc7ClVQREFURSBwYXBlcl9maWxlcyBTRVQgZmlsZV90eXBl ID0gJ2FwcGxpY2F0aW9uL3ZuZC5vcGVueG1sZm9ybWF0cy1vZmZpY2Vkb2N1bWVudC5wcmVzZW50 YXRpb25tbC5wcmVzZW50YXRpb24nIFdIRVJFIG9yaWdpbmFsX2ZpbGVfbmFtZSB+KiAnLnBwdHgk JzsKVVBEQVRFIHBhcGVyX2ZpbGVzIFNFVCBmaWxlX3R5cGUgPSAnYXBwbGljYXRpb24vdm5kLm9w ZW54bWxmb3JtYXRzLW9mZmljZWRvY3VtZW50LnByZXNlbnRhdGlvbm1sLnNsaWRlc2hvdycgV0hF UkUgb3JpZ2luYWxfZmlsZV9uYW1lIH4qICcucHBzeCQnOw== 3660 2011-10-11 22:23:00 -0700 2011-10-11 22:23:12 -0700 OJS MySQL database update 6876_ojs_mysql.sql text/plain 881 michael.pkp VVBEQVRFIGFydGljbGVfZmlsZXMgU0VUIGZpbGVfdHlwZSA9ICdhcHBsaWNhdGlvbi9wZGYnIFdI RVJFIG9yaWdpbmFsX2ZpbGVfbmFtZSBSTElLRSAnXFwucGRmJCc7ClVQREFURSBhcnRpY2xlX2Zp bGVzIFNFVCBmaWxlX3R5cGUgPSAnYXBwbGljYXRpb24vbXN3b3JkJyBXSEVSRSBvcmlnaW5hbF9m aWxlX25hbWUgUkxJS0UgJ1xcLmRvYyQnOwpVUERBVEUgYXJ0aWNsZV9maWxlcyBTRVQgZmlsZV90 eXBlID0gJ2FwcGxpY2F0aW9uL3ZuZC5tcy1wb3dlcnBvaW50JyBXSEVSRSBvcmlnaW5hbF9maWxl X25hbWUgUkxJS0UgJ1xcLnBwdCQnOwpVUERBVEUgYXJ0aWNsZV9maWxlcyBTRVQgZmlsZV90eXBl ID0gJ2FwcGxpY2F0aW9uL3ZuZC5tcy1wb3dlcnBvaW50JyBXSEVSRSBvcmlnaW5hbF9maWxlX25h bWUgUkxJS0UgJ1xcLnBwcyQnOwpVUERBVEUgYXJ0aWNsZV9maWxlcyBTRVQgZmlsZV90eXBlID0g J2FwcGxpY2F0aW9uL3ZuZC5vcGVueG1sZm9ybWF0cy1vZmZpY2Vkb2N1bWVudC53b3JkcHJvY2Vz c2luZ21sLmRvY3VtZW50JyBXSEVSRSBvcmlnaW5hbF9maWxlX25hbWUgUkxJS0UgJ1xcLmRvY3gk JzsKVVBEQVRFIGFydGljbGVfZmlsZXMgU0VUIGZpbGVfdHlwZSA9ICdhcHBsaWNhdGlvbi92bmQu b3BlbnhtbGZvcm1hdHMtb2ZmaWNlZG9jdW1lbnQucHJlc2VudGF0aW9ubWwucHJlc2VudGF0aW9u JyBXSEVSRSBvcmlnaW5hbF9maWxlX25hbWUgUkxJS0UgJ1xcLnBwdHgkJzsKVVBEQVRFIGFydGlj bGVfZmlsZXMgU0VUIGZpbGVfdHlwZSA9ICdhcHBsaWNhdGlvbi92bmQub3BlbnhtbGZvcm1hdHMt b2ZmaWNlZG9jdW1lbnQucHJlc2VudGF0aW9ubWwuc2xpZGVzaG93JyBXSEVSRSBvcmlnaW5hbF9m aWxlX25hbWUgUkxJS0UgJ1xcLnBwc3gkJzs= 3661 2011-10-11 22:23:00 -0700 2011-10-11 22:23:42 -0700 OJS PostgreSQL database update 6876_ojs_pgsql.sql text/plain 846 michael.pkp VVBEQVRFIGFydGljbGVfZmlsZXMgU0VUIGZpbGVfdHlwZSA9ICdhcHBsaWNhdGlvbi9wZGYnIFdI RVJFIG9yaWdpbmFsX2ZpbGVfbmFtZSB+KiAnLnBkZiQnOwpVUERBVEUgYXJ0aWNsZV9maWxlcyBT RVQgZmlsZV90eXBlID0gJ2FwcGxpY2F0aW9uL21zd29yZCcgV0hFUkUgb3JpZ2luYWxfZmlsZV9u YW1lIH4qICcuZG9jJCc7ClVQREFURSBhcnRpY2xlX2ZpbGVzIFNFVCBmaWxlX3R5cGUgPSAnYXBw bGljYXRpb24vdm5kLm1zLXBvd2VycG9pbnQnIFdIRVJFIG9yaWdpbmFsX2ZpbGVfbmFtZSB+KiAn LnBwdCQnOwpVUERBVEUgYXJ0aWNsZV9maWxlcyBTRVQgZmlsZV90eXBlID0gJ2FwcGxpY2F0aW9u L3ZuZC5tcy1wb3dlcnBvaW50JyBXSEVSRSBvcmlnaW5hbF9maWxlX25hbWUgfiogJy5wcHMkJzsK VVBEQVRFIGFydGljbGVfZmlsZXMgU0VUIGZpbGVfdHlwZSA9ICdhcHBsaWNhdGlvbi92bmQub3Bl bnhtbGZvcm1hdHMtb2ZmaWNlZG9jdW1lbnQud29yZHByb2Nlc3NpbmdtbC5kb2N1bWVudCcgV0hF UkUgb3JpZ2luYWxfZmlsZV9uYW1lIH4qICcuZG9jeCQnOwpVUERBVEUgYXJ0aWNsZV9maWxlcyBT RVQgZmlsZV90eXBlID0gJ2FwcGxpY2F0aW9uL3ZuZC5vcGVueG1sZm9ybWF0cy1vZmZpY2Vkb2N1 bWVudC5wcmVzZW50YXRpb25tbC5wcmVzZW50YXRpb24nIFdIRVJFIG9yaWdpbmFsX2ZpbGVfbmFt ZSB+KiAnLnBwdHgkJzsKVVBEQVRFIGFydGljbGVfZmlsZXMgU0VUIGZpbGVfdHlwZSA9ICdhcHBs aWNhdGlvbi92bmQub3BlbnhtbGZvcm1hdHMtb2ZmaWNlZG9jdW1lbnQucHJlc2VudGF0aW9ubWwu c2xpZGVzaG93JyBXSEVSRSBvcmlnaW5hbF9maWxlX25hbWUgfiogJy5wcHN4JCc7