6802 2011-08-03 13:06:00 -0700 New submission notifications not sent to editors 2011-08-04 12:12:31 -0700 1 1 1 Unclassified OJS Editors 2.3.7 All All RESOLVED FIXED P3 normal --- 1 mattcrider pkp-support alec 24612 mattcrider 2011-08-03 13:06:13 -0700 List of editors not properly constructed when sending new article notification. 24613 3606 mattcrider 2011-08-03 13:11:27 -0700 Created attachment 3606 Patch against OJS 2.3.6 24614 alec 2011-08-03 13:19:48 -0700 Needs porting to OCS. Also, beware of references -- if you pass the object off to another function it may behave unexpectedly. The best pattern to use is: while ($object = $iterator->next()) { // Do something } 24615 mattcrider 2011-08-03 13:20:02 -0700 Fix editor list construction for new article notifications https://github.com/pkp/ojs/commit/3d5e0ef8d00e31ae76b16da816e00cbcb9f6098e 24616 mattcrider 2011-08-03 13:20:02 -0700 Fix editor list construction for new article notifications https://github.com/pkp/ojs/commit/4ec1fb590dc5d9eacba6e0ca3890dd8eed68c348 24617 mattcrider 2011-08-03 14:10:02 -0700 Cleaned up editor selection for new submission notification https://github.com/pkp/ocs/commit/365a4c8f4136385984e33108c6ea80f103456852 24618 mattcrider 2011-08-03 14:10:02 -0700 Cleaned up editor selection for new submission notification https://github.com/pkp/ocs/commit/d10549d68ee04486e6c6941a42663a4b52fecb7e 24619 mattcrider 2011-08-03 14:10:02 -0700 Cleaned up editor selection for new submission notification https://github.com/pkp/ojs/commit/0aec01b4e9dd90e1b53d9d24b4dc22e05f0e5bcc 24620 3607 mattcrider 2011-08-03 14:13:38 -0700 Created attachment 3607 Patch against OJS 2.3.6 24621 alec 2011-08-03 14:18:17 -0700 Attachment #3607 is OK, but in general, beware the reference -- best to use either: while ($thing =& $iterator->next()) { // Do something, then... unset($thing); } ...or don't use references... while ($thing = $iterator->next()) { // Do something } 24622 mattcrider 2011-08-03 14:20:02 -0700 Cleaned up editor selection for new submission notification https://github.com/pkp/ojs/commit/6e172849d367481b122d23cea01a96c267ce515c 24623 mattcrider 2011-08-03 14:20:41 -0700 I am unsetting $editor -- its just not in the patch (was already doing it). 24624 alec 2011-08-03 14:36:52 -0700 Great! Didn't see that. 24641 mattcrider 2011-08-04 12:12:31 -0700 Think we're all done here.. 3606 2011-08-03 13:11:00 -0700 2011-08-03 14:13:38 -0700 Patch against OJS 2.3.6 6802.patch text/plain 882 mattcrider ZGlmZiAtLWdpdCBhL3BhZ2VzL2F1dGhvci9TdWJtaXRIYW5kbGVyLmluYy5waHAgYi9wYWdlcy9h dXRob3IvU3VibWl0SGFuZGxlci5pbmMucGhwCmluZGV4IDZiMGIzYWYuLjJkNzI0ODQgMTAwNjQ0 Ci0tLSBhL3BhZ2VzL2F1dGhvci9TdWJtaXRIYW5kbGVyLmluYy5waHAKKysrIGIvcGFnZXMvYXV0 aG9yL1N1Ym1pdEhhbmRsZXIuaW5jLnBocApAQCAtMTYzLDkgKzE2Myw5IEBAIGNsYXNzIFN1Ym1p dEhhbmRsZXIgZXh0ZW5kcyBBdXRob3JIYW5kbGVyIHsKIAkJCQkJJGFydGljbGUgPSYgJGFydGlj bGVEYW8tPmdldEFydGljbGUoJGFydGljbGVJZCk7CiAJCQkJCSRyb2xlRGFvID0mIERBT1JlZ2lz dHJ5OjpnZXREQU8oJ1JvbGVEQU8nKTsKIAkJCQkJJG5vdGlmaWNhdGlvblVzZXJzID0gYXJyYXko KTsKLQkJCQkJJGVkaXRvcnMgPSAkcm9sZURhby0+Z2V0VXNlcnNCeVJvbGVJZChST0xFX0lEX0VE SVRPUik7Ci0JCQkJCSRub3RpZnlVc2VycyA9ICRlZGl0b3JzLT50b0FycmF5KCk7Ci0JCQkJCXdo aWxlICgkZWRpdG9yID0mICRlZGl0b3JzLT5uZXh0KCkpIHsKKwkJCQkJJGVkaXRvcnMgPSAkcm9s ZURhby0+Z2V0VXNlcnNCeVJvbGVJZChST0xFX0lEX0VESVRPUiwgJGpvdXJuYWwtPmdldElkKCkp OworCQkJCQl3aGlsZSAoISRlZGl0b3JzLT5lb2YoKSkgeworCQkJCQkJJGVkaXRvciA9JiAkZWRp dG9ycy0+bmV4dCgpOwogCQkJCQkJJHVybCA9ICRyZXF1ZXN0LT51cmwobnVsbCwgJ2VkaXRvcics ICdzdWJtaXNzaW9uJywgJGFydGljbGVJZCk7CiAJCQkJCQkkbm90aWZpY2F0aW9uTWFuYWdlci0+ Y3JlYXRlTm90aWZpY2F0aW9uKAogCQkJCQkJCSRlZGl0b3ItPmdldElkKCksICdub3RpZmljYXRp b24udHlwZS5hcnRpY2xlU3VibWl0dGVkJywK 3607 2011-08-03 14:13:00 -0700 2011-08-03 14:13:38 -0700 Patch against OJS 2.3.6 6802.patch text/plain 749 mattcrider ZGlmZiAtLWdpdCBhL3BhZ2VzL2F1dGhvci9TdWJtaXRIYW5kbGVyLmluYy5waHAgYi9wYWdlcy9h dXRob3IvU3VibWl0SGFuZGxlci5pbmMucGhwCmluZGV4IDZiMGIzYWYuLjJkZWRhOTYgMTAwNjQ0 Ci0tLSBhL3BhZ2VzL2F1dGhvci9TdWJtaXRIYW5kbGVyLmluYy5waHAKKysrIGIvcGFnZXMvYXV0 aG9yL1N1Ym1pdEhhbmRsZXIuaW5jLnBocApAQCAtMTYzLDggKzE2Myw3IEBAIGNsYXNzIFN1Ym1p dEhhbmRsZXIgZXh0ZW5kcyBBdXRob3JIYW5kbGVyIHsKIAkJCQkJJGFydGljbGUgPSYgJGFydGlj bGVEYW8tPmdldEFydGljbGUoJGFydGljbGVJZCk7CiAJCQkJCSRyb2xlRGFvID0mIERBT1JlZ2lz dHJ5OjpnZXREQU8oJ1JvbGVEQU8nKTsKIAkJCQkJJG5vdGlmaWNhdGlvblVzZXJzID0gYXJyYXko KTsKLQkJCQkJJGVkaXRvcnMgPSAkcm9sZURhby0+Z2V0VXNlcnNCeVJvbGVJZChST0xFX0lEX0VE SVRPUik7Ci0JCQkJCSRub3RpZnlVc2VycyA9ICRlZGl0b3JzLT50b0FycmF5KCk7CisJCQkJCSRl ZGl0b3JzID0gJHJvbGVEYW8tPmdldFVzZXJzQnlSb2xlSWQoUk9MRV9JRF9FRElUT1IsICRqb3Vy bmFsLT5nZXRJZCgpKTsKIAkJCQkJd2hpbGUgKCRlZGl0b3IgPSYgJGVkaXRvcnMtPm5leHQoKSkg ewogCQkJCQkJJHVybCA9ICRyZXF1ZXN0LT51cmwobnVsbCwgJ2VkaXRvcicsICdzdWJtaXNzaW9u JywgJGFydGljbGVJZCk7CiAJCQkJCQkkbm90aWZpY2F0aW9uTWFuYWdlci0+Y3JlYXRlTm90aWZp Y2F0aW9uKAo=